Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/accordion svg duped class attribute #2597

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

endigo9740
Copy link
Contributor

@endigo9740 endigo9740 commented Apr 5, 2024

Linked Issue

Closes #2586

Description

Fixes AccordionItem caret classesControlCaret class duplicated on the SVG element

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@endigo9740 endigo9740 linked an issue Apr 5, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: 24b9e77

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-next 🔄 Building (Inspect) Visit Preview Apr 5, 2024 10:07pm
skeleton-themes 🛑 Canceled (Inspect) Apr 5, 2024 10:07pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
skeleton-docs ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 10:07pm

@endigo9740 endigo9740 merged commit c5aafca into dev Apr 5, 2024
5 of 7 checks passed
@endigo9740 endigo9740 deleted the bugfix/accordion-svg-duped-class-attribute branch April 5, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion caret classesControlCaret is repeated on SVG element
1 participant