-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/toast transition error when triggered/closing at the same tick #2622
Bugfix/toast transition error when triggered/closing at the same tick #2622
Conversation
🦋 Changeset detectedLatest commit: 2588708 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@VitAndrGuid is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
@VitAndrGuid I've restored the missing portion of the PR template concerning changesets and the checklist. If you could please run down the checklist and verify all conditions are met please. Note I handle PR reviews periodically, so it may be a couple days before I get to this. But I will review asap. |
@endigo9740 |
@VitAndrGuid the PR was still in a "draft" state, so I wasn't sure if were quite done and ready for review. But assuming so, I've completed an audit and everything looks to meet my expectations. I especially appreciate you adding the test case! If you would please confirm everything is ready on your end, I'll go ahead and accept and merge this. If we can get this in over the next few day it can go out as part of the new release on Tuesday next week. Thanks! |
@endigo9740 |
Linked Issue
Closes #2407
Description
Whenever transitions are enabled and a second toast is triggered immediately after the first one is closed, the toast wrapper is removed from the DOM and the second toast is not displayed.
This happens because the wrapper depends on a IF block thats only true when theres a toast on the queue, but when a first toast
A
is removed and a second oneB
is immediately added it seems the update of the removal of the toast wrapper, scheduled by the removal ofA
is executed afterA
outro animation ends, in this caseB
will be shown for a mere moment and then the wrapper is removed, but it should be visible sinceB
is on the queue.Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test