-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optionally prioritize new toasts #2673
feat: optionally prioritize new toasts #2673
Conversation
…itized if total number of toasts is greater than max. Older toasts are not automatically dismissed though, just not visible unless the newer toasts dissapear first.
🦋 Changeset detectedLatest commit: 6e97cb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@HenryMBaldwin is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
@HenryMBaldwin first off sorry for the long delay on this one. We've been snowed in with our pre-release prep and launches of Skeleton v3 and Floating UI Svelte. I actually think this is a very interesting feature, and you've done a great job of following our contribution guidelines, so thanks for that. I can definitely see the appear of this feature, however, I'm cautious of adding new features this late in v2's lifecycle. As such I'm going to recommend we do the following:
The v3 overlay system will see us combining toasts/drawers/modals under a singular system so they can have a consistent set of features. This has a number of positive implications for users. The result will be we can add your feature once, and it'll be available for all three! Again, I appreciate the contribution and please do look forward to a version of this feature coming in the future. Thanks again, |
Description
Added prioritizeNew prop to Toast.svelte to allow enabling/disabling prioritizing newer toasts when the total number of toasts exceed the maximum. Currently older toasts are prioritized, and this is still the stock behavior as the prop defaults to false.
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test