New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom typescript exports on package #72

Closed

niktek wants to merge 1 commit into skeletonlabs:master from niktek:feat/custom-ts-exports

Contributor

niktek commented Aug 11, 2022

This little script will append the custom exports in src/lib/custom.d.ts to the auto generated package/index.d.ts created by svelte-kit package.

The real fix needs to be upstream, but svelte-kit package is marked as experimental and not likely to be improved until after the v1 release of SK


          Added custom typescript exports on package

332671a

niktek mentioned this pull request

Missing Dialog and Snackbar type exports #47

Closed

thomasbjespersen requested review from endigo9740 and thomasbjespersen

August 11, 2022 02:33

Contributor

endigo9740 commented Aug 11, 2022 •

edited

Loading

@niktek We need a few things to make this perfect:

Need to add the custom type for Toasts as well. There's just one, exactly like Dialog types, defined in the same location.
Need to update the Utilities > Dialog docs to reference the new short import snippet
Need to update the Utilities > Toast docs to reference the new short import snippet

I think with that we'll be golden!

endigo9740 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet