added ACL canonical view #28
Conversation
|
See more info at #22 |
msldap/examples/msldapclient.py
Outdated
| @@ -184,7 +186,7 @@ async def do_query(self, query, attributes = None): | |||
| async for entry, err in self.connection.pagedsearch(query, attributes): | |||
| if err is not None: | |||
| raise err | |||
| print(entry) | |||
There was a problem hiding this comment.
I know the current version is not the best, but using JSON will break a lot of things because the enrty variable can hold objects which are not JSON serializable.
| @@ -406,7 +408,7 @@ async def do_setsd(self, target_dn, sddl): | |||
| traceback.print_exc() | |||
| return False | |||
|
|
|||
| async def do_getsd(self, dn): | |||
There was a problem hiding this comment.
Please do not extend this function to add your functionality, just create a new one with the name do_getsdpp or something similarly short and descriptive.
The output of this function MUST be in the current format, as the same output can be used as an input to the do_setsd and it's guaranteed to reproduce the same SD (or at least very close to it)
There was a problem hiding this comment.
I left original functionality of getsd - if we use this command without parameters
There was a problem hiding this comment.
Whats about getsd? Should I separate this functional by getsdp and getsdg. Or we use tune behaviour via argument.
Currently It supports:
getsd DN- SDDL outputgetsd DN g|grep|greppable- canonical greppable ACEs view (horizontal)getsd DN p|pretty- canonical scrollable vertical view (vertical)
|
ping |
|
Thank you, merged it. Packaging will follow soon |
Hello.
I've implemented a bit changes for ACL analysis.