test: e2e testing final #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
davidterpay,
nivasan1 and
Eric-Warehime
as code owners
nivasan1
reviewed
May 17, 2024
| fee := s.QueryBaseFee() | ||
| s.T().Log("base fee", fee.String()) | ||
|
|
||
| if fee.AmountOf(feemarkettypes.DefaultFeeDenom).Equal(params.MinBaseFee) { |
There was a problem hiding this comment.
we are checking that the fee has decreased and been "clamped" to the min base fee
|
|
||
| amt, err := s.chain.GetBalance(context.Background(), s.user1.FormattedAddress(), baseFee[0].Denom) | ||
| s.Require().NoError(err) | ||
| s.Require().True(amt.LT(math.NewInt(initBalance)), amt) |
There was a problem hiding this comment.
Looks like we're checking the balance of user1's account? Are we not verifying properties of the fee-state here as well?
There was a problem hiding this comment.
We are already checking the movement of the fee state in the for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BLO-1236