Crash of skip_server if subclass is removed #72
Comments
pikatchu
added a commit
that referenced
this issue
Oct 28, 2019
Up until now, the values used in a reactive table had to implement a bunch of traits (such as Equality, Orderable etc ...). The reason was that the implementation was relying on a sort of those values to function properly (compute the diffs etc ...). The other weird thing is that the implementation was returning a sorted array of the values inserted and was perform a "unique" operation on them for no good reason other than it was convenient for the old implementation. This new implementation fixes that, the values don't have any constraint other than being frozen (the interned pointer is used to do the operations). The values returned by "get" preserve repetitions. PS: Turns out the new implementation fixed a long standing bug in the incremental type-checker when a module was changing name. PS2: I used the opportunity to also fix issue #72.
pikatchu
added a commit
that referenced
this issue
Nov 12, 2019
* New implementation of reactive tables. Up until now, the values used in a reactive table had to implement a bunch of traits (such as Equality, Orderable etc ...). The reason was that the implementation was relying on a sort of those values to function properly (compute the diffs etc ...). The other weird thing is that the implementation was returning a sorted array of the values inserted and was perform a "unique" operation on them for no good reason other than it was convenient for the old implementation. This new implementation fixes that, the values don't have any constraint other than being frozen (the interned pointer is used to do the operations). The values returned by "get" preserve repetitions. PS: Turns out the new implementation fixed a long standing bug in the incremental type-checker when a module was changing name. PS2: I used the opportunity to also fix issue #72. * removed constraints on Reactive table type parameter * revert changes in skip_to_native
pikatchu
added a commit
that referenced
this issue
Nov 22, 2019
* New implementation of reactive tables. Up until now, the values used in a reactive table had to implement a bunch of traits (such as Equality, Orderable etc ...). The reason was that the implementation was relying on a sort of those values to function properly (compute the diffs etc ...). The other weird thing is that the implementation was returning a sorted array of the values inserted and was perform a "unique" operation on them for no good reason other than it was convenient for the old implementation. This new implementation fixes that, the values don't have any constraint other than being frozen (the interned pointer is used to do the operations). The values returned by "get" preserve repetitions. PS: Turns out the new implementation fixed a long standing bug in the incremental type-checker when a module was changing name. PS2: I used the opportunity to also fix issue #72. * removed constraints on Reactive table type parameter * revert changes in skip_to_native
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
base class A
class B() extends A
Removing the class B makes the server crash
The text was updated successfully, but these errors were encountered: