Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #6

Merged
merged 3 commits into from
Nov 28, 2021
Merged

Develop #6

merged 3 commits into from
Nov 28, 2021

Conversation

MrNereof
Copy link
Member

AFTER INSTALLING NEW VERSION, YOUR CURRENT SESSION WILL ERASED.
Before installing new version, save your session to any folder and import it after installing

=========================================

Added:

Changed:

Fixed:

  1. Access denied on starting Skippy

@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MrNereof MrNereof merged commit 4fafa73 into main Nov 28, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 28, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.16%.

Quality metrics Before After Change
Complexity 1.69 ⭐ 1.74 ⭐ 0.05 👎
Method Length 38.97 ⭐ 39.23 ⭐ 0.26 👎
Working memory 5.52 ⭐ 5.59 ⭐ 0.07 👎
Quality 81.01% 80.85% -0.16% 👎
Other metrics Before After Change
Lines 1629 1663 34
Changed files Quality Before Quality After Quality Change
skippy/init.py 99.00% ⭐ 99.00% ⭐ 0.00%
skippy/app.py 85.68% ⭐ 86.49% ⭐ 0.81% 👍
skippy/config.py 89.18% ⭐ 75.73% ⭐ -13.45% 👎
skippy/api/init.py % % %
skippy/core/autoupdate.py 97.97% ⭐ 97.45% ⭐ -0.52% 👎
skippy/core/plugins.py 93.35% ⭐ 90.91% ⭐ -2.44% 👎
skippy/core/preview.py 80.49% ⭐ 80.49% ⭐ 0.00%
skippy/core/scpclient.py 76.74% ⭐ 74.31% 🙂 -2.43% 👎
skippy/gui/actionbar.py 71.00% 🙂 71.00% 🙂 0.00%
skippy/gui/mainwindow.py 84.85% ⭐ 84.85% ⭐ 0.00%
skippy/gui/sitebox.py 87.32% ⭐ 87.33% ⭐ 0.01% 👍
skippy/gui/tabwidget.py 75.98% ⭐ 76.10% ⭐ 0.12% 👍
skippy/gui/dialogs/upload.py 61.20% 🙂 61.20% 🙂 0.00%
skippy/plugins/example_plugin.py 100.00% ⭐ 100.00% ⭐ 0.00%
skippy/utils/init.py % 97.87% ⭐ %
skippy/utils/filehandlers.py 92.90% ⭐ 92.90% ⭐ 0.00%
skippy/utils/standarddir.py 97.09% ⭐ 96.01% ⭐ -1.08% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
skippy/gui/actionbar.py ActionBarBase.initActions 1 ⭐ 542 ⛔ 8 🙂 53.33% 🙂 Try splitting into smaller methods
skippy/gui/dialogs/upload.py UploadDialog.__init__ 2 ⭐ 231 ⛔ 10 😞 54.33% 🙂 Try splitting into smaller methods. Extract out complex expressions
skippy/core/preview.py IncludesProcessor.process 11 🙂 150 😞 9 🙂 54.36% 🙂 Try splitting into smaller methods
skippy/core/scpclient.py SCPClient.upload 9 🙂 154 😞 9 🙂 55.77% 🙂 Try splitting into smaller methods
skippy/gui/tabwidget.py TabWidget.__init__ 0 ⭐ 219 ⛔ 10 😞 57.07% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant