-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors when running skip checkup
if java version > 17
#5
Comments
Additional info: Here's build error log when trying to build hello-skip project created via command
|
I got the same error, please keep me updated if you find the solution. |
I found the solution, I had a newer version of JDK installed. Follow this documentation to uninstall your current version if it is above 17 or simply install version 17. |
Yep, working now. Thanks for your help! cd /Library/Java/JavaVirtualMachines
sudo rm -rf JDK>17 # replace by your idk version
brew install openjdk@17 Issue can be closed (but info should be added to the installation readme?) |
skip checkup
skip checkup
if java version > 17
Even unistalling the newer JDK and installing openjdk@17 did not worked
It only worked when i added below line to the Build Android APK build phase script
|
We released Skip 0.7.13 last night, which adds Also, if you have a custom For some background, Skip would like to be hands-off about which Java version it uses, since Android-focused developers may have limitations and needs for specific version. However, there's an open Gradle issue that prevents JDK 21 from working at all for Android builds; this is a problem for Homebrew's default recommended JDK |
I'm using Skip This solution worked #5 (comment) |
I had to add
instead of |
Skip 0.7.16 adds some additional logic to use the Please let us know if this problem still affects you and we will re-open the issue. |
I am using latest Skip version 0.7.31 but still facing the above issues. |
Can you post the output of |
|
The problem is from this part of the log:
Can you try forcing using openjdk 17 with the command:
And then check the output of the
|
I followed those steps but it didn't work. It seems skip is still choosing JDK version 21? Here is the output.
|
I had the same problem @rzil :
I fixed it, you can follow these instructions (not final fix):
@marcprux Inside the homebrew configuration file , the openjdk@21 is used, maybe the issue could come from here? This is my first time searching for an error with Homebrew, so I might be mistaken. |
Yes that did the trick. Need to set |
Apologies for not getting back on this sooner. We're still working through some of the issues with Gradle 8.5 and OpenJDK. If you Please let us know if this helps. |
I followed these steps, still failed in the apk step I have 17.0.10 jdk installed. I also have react native/expo installed globally, may this be causing the error? [✗] Assembling Android apk (12.99s) |
Warning: openjdk@17 17.0.9 is already installed and up-to-date. nat-serrano@Nats-MacBook-Pro-2 JavaVirtualMachines % java -version nat-serrano@Nats-MacBook-Pro-2 JavaVirtualMachines % echo $JAVA_HOME |
I think that problem was a different one that should be resolved if you |
I tried to upgrade to 0.8.4 but didn't actually upgrade |
Can you try running |
As you seem to have surmised, this is the problem:
You should remove any reference to JAVA_HOME in your If that continues to fail, can you post the log file mentioned at the end of the command? |
From the log:
Can you check whether the folder Also, was your machine upgraded from an Intel to an ARM (e.g., M1)? If so, the Homebrew installation may be an old Intel-based version, which sometimes installs the wrong architecture for packages. In these cases (which can be identified by the existence of a |
Hello, sorry for the lack of news. Trying this again :
I do use a M1 Pro machine, EDIT : I fixed it by running :
then
|
Error after first installation via brew and running
skip checkup
(with and without--double-check
)Maybe we can provide more info, to help resolving this issue?
Discussed in #4
Originally posted by oluarry October 27, 2023
This error came up when trying to build in xcode
I followed all the steps and made 2 different projects but same error in xcode
I ran skip doublecheck here
The text was updated successfully, but these errors were encountered: