skk-jisyo can accept (PATH . CODING) cons-cell. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elim
added a commit
to elim/ddskk
that referenced
this pull request
Mar 9, 2020
This change supplements recent Pull Request skk-dev#132. (commit: b8ba590)
This was referenced Mar 9, 2020
tats
reviewed
Mar 9, 2020
Comment on lines
+3851
to
+3852
| ((equal file (car skk-jisyo)) | ||
| (cdr skk-jisyo)) |
There was a problem hiding this comment.
skk-jisyoがデフォルト値のstringだと(car skk-jisyo)のところで
wrong-type-argumentのエラーになります。
cf. #133
(car-safe skk-jisyo)にすればエラーは収まりますが、そもそも
skk-get-jisyo-bufferはすでに(PATH . CODING)に対応済なのだから、
呼び出し元でskk-carを使わずにskk-jisyoをそのまま渡せば、
skk-jisyo独自対応は不要なのではないでしょうか。
tkita
added a commit
to tkita/ddskk
that referenced
this pull request
Mar 10, 2020
tkita
added a commit
that referenced
this pull request
Mar 10, 2020
#132 fix. New function skk-jisyo
tkita
added a commit
to tkita/ddskk
that referenced
this pull request
Mar 14, 2020
tkita
added a commit
that referenced
this pull request
Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etc/dot.emacs に設定例があります．