Change-Id: Id7fbee08e3ea563d2f2d804d198169745c8feb2f

Change-Id: I3b1a1630d4d7630465e1c202db18c3357ca61650

Change-Id: I294eb860fa2bfa313035bf52b9b8e85c9daafb06

Change-Id: I60eeadb7e75de08a96b56ff174ba85ea474054c5

Post grades lti tools will not allow section level assignment
posting, so we should disable their "post grades" buttons when a section
is selected. Pschool post grades jobs, on the other hand, do allow for
section level posting, so we should keep the pschool post grades button
available when properly configured sections are selected.

Test Plan:
  * configure at least 1 sis_app post grades tool
    * get local sisapp running
    * /accounts/1/settings/configurations
    * add app, by url http://<local sisapp>/post_grades/config.xml
  * enable "post grades to sis" (pschool) feature option in settings
  * configure at least 1 course
    * configure at least 1 section with sis id
    * configure at least 1 section without sis id
  * add and publish at least 1 assignment for both the course and
    section
  * navigate to gradebook, and notice that "post grades" dropdown
    appears
  * pick section with sis ID
    * lti tool post grades should become unavailable, but pschool button
      should still be available
  * pick section without sis ID
    * neither post grades button should be available

closes CNVS-21938

Change-Id: Id1236bef304479e7043229687658faed483ad505
Reviewed-on: https://gerrit.instructure.com/58982
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
QA-Review: Ben Bolton <bbolton@instructure.com>
Product-Review: Jonathan Featherstone <jfeatherstone@instructure.com>

Change-Id: I69deacaa45d3a4b3582715bbe78eda08c4e614a8

Change-Id: I888c2ffc2075cddd2cb9a069d039996feea5d1d4

Change-Id: I6cfdb35983e56f533fd8d0fe245da5a962dacdaf

Change-Id: I3604cde8aa13cb1af8fcc91c483e7d3c665598fc

Fixes CNVS-22084

Test plan:
 - Create a course
 - Add some students to the course
 - Ensure that the course is unpublished
 - Create some groups in the course
 - Ensure that you can add and remove students to and from the
   groups in the course
 - Ensure you can otherwise manage groups as you would expect to
   be able to even though the course is unpublished

Change-Id: I0c5ecd551c018f7bde08ffed566ecf3a15b8429a
Reviewed-on: https://gerrit.instructure.com/59043
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Jenkins
Reviewed-by: Joel Hough <joel@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>

test plan:
* should fix quiz question point importing

* should also fix assignments for moodle 2.1 packages

(import the packages references in the ticket)

closes #CNVS-21870 #CNVS-21863

Change-Id: I6606721882f6e792b65bef0237c000441a9ba6d1
Reviewed-on: https://gerrit.instructure.com/59224
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
QA-Review: Pedro Fajardo <pfajardo@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>

the way this was written, it used to fire off
a promise for every brand all at the same time.

I’ve changed it so the memory usage will be more
like `k * <# variants>` instead of
`<# of themes> * <# variants> * k`
so it will stay constant (on my machine ~500mb) and
not grow huge as we get more people that have made
themes.  (where k is the memory it takes to
compile one sass file, and # themes is a constant,
in our case 6.

Change-Id: I1fa4b4410a1141b461019f0c614ba343ea73000c
Reviewed-on: https://gerrit.instructure.com/59182
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>

refs CNVS-21215

test plan
- setup incoming mail processing
- cause an email duplicate to be sent (Mail gem and a console are
 great for this. the message id has to be the same)
- ensure that the response is not double posted in canvas

Change-Id: I2e6872fa430b38b5dd9498ce8329bf2bbeeea7ce
Reviewed-on: https://gerrit.instructure.com/57566
Tested-by: Jenkins
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>

Fixes CNVS-21220

Test Plan:

Test with CNVS-21215 & 21218

Change-Id: I194e66e25cd3e85718381735055aa6bbec9c4936
Reviewed-on: https://gerrit.instructure.com/58636
Reviewed-by: Joel Hough <joel@instructure.com>
Product-Review: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Tested-by: Jenkins

fixes: CNVS-22155

see: ryankshaw/brandable_css@e1b5a8e?diff=unified#diff-2b4ca49d4bb0a774c4d4c1672d7aa781R23

test plan:

say the path to your canvas-lms repos is in
/Users/ryan/code/canvas-lms

make a symlink that points to that in:
/Users/ryan/current

run `brandable_css`
it should work

Change-Id: I1f732a53e56ea376efe6cd7d54b3ae52178ac025
Reviewed-on: https://gerrit.instructure.com/59342
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>

test plan:
* first, clear out all the cdn assets on your test
s3 bucket by running this in rails console:
Canvas::CDN::S3Uploader.new.bucket.objects.with_prefix('dist').delete_all
* compile_assets
* run bundle exec rake canvas:cdn:upload_to_s3
* access canvas in your browser
* on js/css/image assets (like common-xxxxx.js)
  you should see a "max age 1 year" header

Change-Id: I7847e614a0e3066686bda32f8854263f78cc168f
Reviewed-on: https://gerrit.instructure.com/59184
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>

...because apparently "it's preloading. for
autoloading, CDN will look for cdn or c_d_n.

then in prod mode, it's somewhat different. like
autoloading is disabled? and it just pre-requires
everything in the autoload dirs"

test plan:

run `RAILS_ENV=production bundle exec rake canvas:cdn:upload_to_s3`

it should work

Change-Id: I5deed1cc2b9daa678465b174af320cf1724fea8c
Reviewed-on: https://gerrit.instructure.com/59341
Reviewed-by: James Williams  <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>

fixes CNVS-21883

Change-Id: Ic65ae6db130d12c3a4ef96d6559981bb893fb6ff
Reviewed-on: https://gerrit.instructure.com/59149
Reviewed-by: Spencer Olson <solson@instructure.com>
Tested-by: Jenkins
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Dylan Ross <dross@instructure.com>

Fix boolean checks so api submission index returns an empty array to a student
that has no submissions

Fixes MBL-4441

Test plan
 - create a quiz
 - create a student
 - as the student make an api request for the student's submissions
 - should get empty array not 401

Change-Id: Ie73c1cb00c40fc5d884664bf676d1c305218ff8f
Reviewed-on: https://gerrit.instructure.com/59201
Reviewed-by: Ryan Taylor <rtaylor@instructure.com>
Tested-by: Jenkins
QA-Review: Michael Hargiss <mhargiss@instructure.com>
Product-Review: Brian Finney <bfinney@instructure.com>

Fixes CNVS-22084

Test plan:
 - Create a course
 - Add some students to the course
 - Ensure that the course is unpublished
 - Create some groups in the course
 - Ensure that you can add and remove students to and from the
   groups in the course
 - Ensure you can otherwise manage groups as you would expect to
   be able to even though the course is unpublished

Change-Id: I0c5ecd551c018f7bde08ffed566ecf3a15b8429a
Reviewed-on: https://gerrit.instructure.com/59043
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
Tested-by: Jenkins
Reviewed-by: Joel Hough <joel@instructure.com>
Reviewed-by: Matthew Wheeler <mwheeler@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Peyton Craighill <pcraighill@instructure.com>

Reduces the scope of information returned unnecessarily.

Closes CNVS-22197

Test Plan:
  - Confirm there is no answer weights or exact numerical answers data
    leaked via POST events to the /api/v1/quiz_submissions/:id/questions
    answering event.

Change-Id: Icfd85b6b669b3a61a1acc503b52c78ba346bfb19
Reviewed-on: https://gerrit.instructure.com/59359
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>

Reduces the scope of information returned unnecessarily.

Closes CNVS-22197

Test Plan:
  - Confirm there is no answer weights or exact numerical answers data
    leaked via POST events to the /api/v1/quiz_submissions/:id/questions
    answering event.

Change-Id: Icfd85b6b669b3a61a1acc503b52c78ba346bfb19
Reviewed-on: https://gerrit.instructure.com/59359
Reviewed-by: John Corrigan <jcorrigan@instructure.com>
Tested-by: Jenkins
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Ryan Taylor <rtaylor@instructure.com>

Change-Id: I132d8eb1d3e23be2adbc123395b73cab7d1789bc

closes #CNVS-21870 frd

Change-Id: I94a4b1794ada6af444647e6a8dbb06874d2e25f7
Reviewed-on: https://gerrit.instructure.com/59354
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Pedro Fajardo <pfajardo@instructure.com>

fixes CNVS-22073

test plan:
  - go to theme editor
  - add an image and then undo
    having added that image
  - if that is the only thing youve
    changed so far, you do not get
    a preview button
  - once you change something else
    you can hit preview and it saves
    properly

  - apply theme with a non-default image
  - go to the editor and change back
    to default
  - you get an option to preview with
    the default
  - preview is successful

  - color & image changes act normally

Change-Id: Ia5de701177137625e65434ac316c22aec0e1dd39
Reviewed-on: https://gerrit.instructure.com/59056
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins

fixes: CNVS-22185

Because the the update_progress callback from the
upload_to_s3 callback was happening inside a
Parallel.each thread, we'd get random errors where
it ran out of active record postgres connections.
eg:
ActiveRecord::ConnectionTimeoutError
could not obtain a database connection within 5
seconds (waited 5.000153379 seconds). The max pool
size is currently 5; consider increasing it.

the fix is to call the callback on the main thread so
any db queries are happening from the normal rails thread.

also, this adds a progress bar so if you run this from
the command line, you'll get a nice progress bar like
https://files.slack.com/files-pri/T028ZAGUD-F0896CFR9/screen_shot_2015-07-28_at_10.19.36_am.png
so that when deployers run the:
`rake brand_configs:generate_and_upload_all`
task, which takes a long time, they have an idea
of how long it is going to take

test plan:

note:this is something that only broke on beta and
not on local machines so to test that this fixes it,
you kinda need to just run it there:

* open theme editor
* make a change
* hit preview
* it should not say there was an error

Change-Id: Ife052ab9573aa677d49d8e5e6c637b0faa2b116e
Reviewed-on: https://gerrit.instructure.com/59407
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>

This reverts commit 597abe9.

Fixes CNVS-22183

Test Plan:
 * Navigate to Scheduler
 * Click on "Create an Appointment Group"
 * Verify there is both a Save & Publish button and a Save button
 * Verify the Save & Publish button is blue, and the save button looks
   less eye-catching
 * Add the Appointment group to a course calendar and click the Save
   button
 * Verify the appointment is saved and
   displays on the list of appointment groups
 * Log in as a student in the course
 * Verify a student cannot see and interact with the appointment group
 * Log back in as a teacher, edit the Appointment group, and click Save
   and Publish
 * Log back in as a student in the course
 * Verify the student can now see and interact with the appointment
   group

Change-Id: I26663df508c8b4024b50f1cbe0c561ca3fb8ac31
Reviewed-on: https://gerrit.instructure.com/59404
Reviewed-by: Jonathan Featherstone <jfeatherstone@instructure.com>
QA-Review: Heath Hales <hhales@instructure.com>
Product-Review: Steven Shepherd <sshepherd@instructure.com>
Tested-by: Jenkins

refs CNVS-21431, CNVS-21425

Test scenarios: https://gist.github.com/junyper/7481e6a2b65a1b799bad

Change-Id: I28b24bce592952acfd33cb1303496b8178f0d4b4
Reviewed-on: https://gerrit.instructure.com/58780
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>

Conflicts:
	app/jsx/theme_editor/ThemeEditor.jsx

closes #CNVS-21870 frd

Change-Id: I94a4b1794ada6af444647e6a8dbb06874d2e25f7
Reviewed-on: https://gerrit.instructure.com/59354
Reviewed-by: Dan Minkevitch <dan@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>
Tested-by: Jenkins
QA-Review: Pedro Fajardo <pfajardo@instructure.com>

Fixes CNVS-22170

Test plan:
 - Create a quiz
 - Set a answer comment to `">'><img src=x onerror=alert(3)>`
 - Take the test and view the resulting answer comment every where you
 can find it
 - Try lots of other forms of html to try and execute javascript

Change-Id: I209b266a648810763e03b602790001034815b44f
Reviewed-on: https://gerrit.instructure.com/59457
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>

test plan:
 - if the moderated grading feature flag is allowed
   or enabled at the root account level:
  - permission should be enabled by default for
    account admins and teachers
  - permission should be disabled by default but
    possible to enable for TAs and custom account roles
  - permission should not be enableable for students,
    designers, and observers
 - if the moderated grading feature flag is disabled
   at the root account level:
  - moderate grades permission should not appear in
    the list of permissions

closes CNVS-21956
closes CNVS-21957

Change-Id: I5a8ec28938921c85ca87b199800ee139a3c1f886
Reviewed-on: https://gerrit.instructure.com/59410
Tested-by: Jenkins
Reviewed-by: Derek Bender <dbender@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Jeremy Stanley <jeremy@instructure.com>

Fixes CNVS-22170

Test plan:
 - Create a quiz
 - Set a answer comment to `">'><img src=x onerror=alert(3)>`
 - Take the test and view the resulting answer comment every where you
 can find it
 - Try lots of other forms of html to try and execute javascript

Change-Id: I209b266a648810763e03b602790001034815b44f
Reviewed-on: https://gerrit.instructure.com/59457
Reviewed-by: Cameron Sutter <csutter@instructure.com>
Tested-by: Jenkins
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>

fixes: CNVS-22215

if you try to run rake brand_configs:generate_and_upload_all
on the production boxes it will fail with:

```LoadError: cannot load such file -- ruby-progressbar```

It's because in order to show you a progressbar of
the upload_to_s3 task, Parallel tries to require
'ruby-progressbar' (which is there on dev/test boxes
since it is a dep of ‘rubocop', but not there in prod).

this will make sure it is there in the production
bundler group too.

test plan:
run: RAILS_ENV=production rake brand_configs:generate_and_upload_all

it should work

Change-Id: I98adad9ee2aa596e88d8293a13592f056b8bbb65
Reviewed-on: https://gerrit.instructure.com/59475
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>
QA-Review: Ryan Shaw <ryan@instructure.com>

fixes: CNVS-22212

test plan:
* delete stuff on your s3 bucket
* compile assets and upload to s3
* go to the files section, the icons for folders
  and documents and stuff (the svgs) should show
  up correctly

Change-Id: Ic3bf717ffa1b8e2d42b7b0e0d569dacbab90d41d
Reviewed-on: https://gerrit.instructure.com/59470
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>

HTML in the answer text field is saved raw. If the question is then
edited by some one else and they edit the answer using tinyMCE, they can
accidentally inject unknown html/js into their DOM. Fixed by escaping
the string in the answer_text input thus the content always shows up as
plain text in tinyMCE.

Fixes CNVS-22213

Test plan:
 - Create quiz
 - Set answer text to `<script>alert("XSS")</script>` using the
 answer_text text input field
 - Click the `pencil` edit icon
 - You should see the `<script>` html in the tinyMCE rich text editor
 - Click `Done`
 - You should not see a js alert.

Change-Id: I05c6d57159a02c098ef3d6320eb7768d4a0658a3
Reviewed-on: https://gerrit.instructure.com/59569
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>

Fixes: CNVS-22070

Test Plan:
	- Go to files page
	- Add a file with long title
	- When the title is exceptionally long,
	  it will not overflow out of the
	  modal header. (The situation here
	  http://screencast.com/t/BICD4QFtRfH
	  should no longer occur)

Change-Id: I1ba1f65281aaa4cc7be39cc89c8c372a6e64c23d
Reviewed-on: https://gerrit.instructure.com/59209
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>

HTML in the answer text field is saved raw. If the question is then
edited by some one else and they edit the answer using tinyMCE, they can
accidentally inject unknown html/js into their DOM. Fixed by escaping
the string in the answer_text input thus the content always shows up as
plain text in tinyMCE.

Fixes CNVS-22213

Test plan:
 - Create quiz
 - Set answer text to `<script>alert("XSS")</script>` using the
 answer_text text input field
 - Click the `pencil` edit icon
 - You should see the `<script>` html in the tinyMCE rich text editor
 - Click `Done`
 - You should not see a js alert.

Change-Id: I05c6d57159a02c098ef3d6320eb7768d4a0658a3
Reviewed-on: https://gerrit.instructure.com/59569
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Adam Stone <astone@instructure.com>
Product-Review: Cameron Sutter <csutter@instructure.com>

fixes: CNVS-22218

IE10 has some buggy behavior when posting forms
using FormData. see more here
https://blog.yorkxin.org/posts/2014/02/06/ajax-with-formdata-is-broken-on-ie10-ie11/

test plan:

* open theme editor in ie10 or ie11
* change something
* press "preview changes"
* it should work

Change-Id: If148e911395601212199f12eae6ae884d8b94509
Reviewed-on: https://gerrit.instructure.com/59588
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>

fixes CNVS-22230

test plan:
* Try to preview a theme with one color. The colors that were not set should be the defaults (not transparent).
* Enter an invalid color, verify that the error message appears and the value is not set to 'transparent'
The above scenarios should now work fine on all supported browsers

Change-Id: I87be354d10c8c109dc0f5bbfb0d69bcd5ad8fa80
Reviewed-on: https://gerrit.instructure.com/59638
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

refs PFS-2327

test plan
* make api calls to the following and verify results:
* /api/v1/courses/:course_id/grading_standards
* /api/v1/accounts/:account_id/grading_standards

Change-Id: Iff552e1f30e7b812d77d7138f6ab2f2a142837cc
Reviewed-on: https://gerrit.instructure.com/59120
Reviewed-by: Mike Nomitch <mnomitch@instructure.com>
Tested-by: Jenkins
QA-Review: Jason Carter <jcarter@instructure.com>
Product-Review: Tyson Brown <tbrown@instructure.com>

…ok" in course menu"

fixes CNVS-22235

This reverts commit e413f82.

Change-Id: I49ada900ceef526f82ef37b6ff5febfe7298eda5
Reviewed-on: https://gerrit.instructure.com/59572
Tested-by: Jenkins
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Erin Hallmark <erin@instructure.com>

fixes: CNVS-22248

High contrast mode is overriding everything, but our primary button,
because this is getting a default hex instead of a variable now. This
will fix it to get the appropriate color when high-contrast mode is on.

Test plan:
- (with default canvas theme) Turn on High-contrast mode.
  - go to /stylguide#buttons
  - Your primary button is now passing contrast (4:5) and should be a darker
blue: example: http://cl.ly/image/211k332A3r2H

- (with edited theme)
  - If you are in high-contrast, they should remain the same blue color
  - If you are in regualr ui, they should change to whatever you choose in Theme
editor for primary button

Change-Id: Ic6a41cc8e7fbb8093c0dcbd91b5ddce8832d9f1f
Reviewed-on: https://gerrit.instructure.com/59627
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

fixes CNVS-22124

Test Plan:
* Add multiple tools to a course with "course_navigation[default]"
  set to "disabled" (using create external_tool api)
* Update one of the tools with "hidden=false" with tabs
* Go to the course's settings page -> navigation tab
* Only the tab you marked as "hidden=false" should be unhidden
  for the external tools you created

Change-Id: I106996778284a3b69d5f82f4c772497524681285
Reviewed-on: https://gerrit.instructure.com/59496
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>

fixes CNVS-22149
fixes CNVS-22150

test plan:
  - go to theme editor with a screenreader
  - input an invalid color
  - when the red error box pops up the
    screenreader reads that the color
    is invalid
  - red error boxes are tabbable
    (though you'll skip past them at
     first, you can tab back)

Change-Id: I84a33a35039fdc064ba2dc51005d777851c493ee
Reviewed-on: https://gerrit.instructure.com/59484
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Tested-by: Jenkins
Product-Review: Aaron Cannon <acannon@instructure.com>

fixes: CNVS-22177

test plan:
* go to the theme editor and try to upload a
 "Mobile Homescreen Icon"
* the helper text should tell you can only use pngs
* and the file picker should only be able to pick
  png files

Change-Id: I9ef7402bd08fdb70512604eefce5e0da1ae8abbb
Reviewed-on: https://gerrit.instructure.com/59406
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

closes: CNVS-22128
fixes: CNVS-22266

before, we just revved everything in public
even though it was never included into the page.
that took forever, especially for things like
the entire bower directory.

this only revs the things we actually include on
the page

test plan:

* rm -rf public/dist
* compile_assets
* notice that gulp rev takes ~800ms instead of forever
* browse canvas in both prod (so it uses optimized js)
and non-optimized
* look at the browser console and make sure you don't
see any 404s

* specifically look at:
analytics: https://jeremyp.beta.instructure.com/accounts/90336
icons in tinymce toolbar
quizzes (specifically the quiz statistics client app stuff ahmad did)

Change-Id: Ia67e79de4f4be23de069d43427af1a3377d72fd2
Reviewed-on: https://gerrit.instructure.com/59183
Tested-by: Jenkins
Reviewed-by: Clay Diffrient <cdiffrient@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>

Fixes: CNVS-22148

Test Plan:
	- In Safari, with VoiceOver enabled,
	  navigate to the settings for the
	  account.

	- Click on the Open Theme Editor
	  button on the right.

	- The icon in the top left should
	  now be ignored completely by
	  VoiceOver and focus should now
	  start on the theme editor's
	  heading.

Change-Id: Ic58819a60f569c882ce8adb4dadc84c235c76231
Reviewed-on: https://gerrit.instructure.com/59441
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Nathan Rogowski <nathan@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>

closes: CNVS-22285

since we took out all usage of the $is-k12 sass variable
when we removed the legacy k12 stuff we did, there
is no actual difference between the new_styles
and k12 variants. so we don't need to generate
2 different files for now (since their output will
be exactly the same).

this will cut the css generation time in half
when deploying and when generating a preview in
theme editor since instead of outputting 2 css files
(1 for new_styles_normal_contrast and 1 for
k12_normal_contrast) for every css bundle for every
theme, we just make one (new_styles_normal_contrast)

In the future, ui/ux might want to reintroduce
a sass variable like $is-k12 to do different things
if they are a k12 school. But when/if we do that,
we can just save it as part of the variables saved
in the school's brand_config from the theme editor.

that will be possible because when you turn on the
k12 feature flag, it defaults to using the
predefined 'K12 Theme' brand_config so *all* k12
schools will have a brand_config

test plan:
make sure canvas looks the same as it did before if
you have the k12 feature flag turned on

Change-Id: I197c30b9c5ed5150a3683f836008cbdbce78b09d
Reviewed-on: https://gerrit.instructure.com/59743
Tested-by: Jenkins
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Colleen Palmer <colleen@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

closes: CNVS-22232

Test Plan:

- Go to Theme Editor
- In hex code box do something like "#0" and cause the red error box to appear
- Add something longer in there ("#92837498798324") to make it a longer
error string
- These should now be working xbrowser without cutting off the box

Old: see ticket
New: http://cl.ly/image/3o2c2c273b18

Change-Id: I941dafc250cb41af632924303f76bde245e6860f
Reviewed-on: https://gerrit.instructure.com/59742
Tested-by: Jenkins
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

Test plan
The following routes should resolve:
  	/api/sis/accounts/sis_account_id:123/assignments
  	/api/sis/courses/sis_course_id:456/assignments

fixes SIS-1310

Change-Id: I0a8057989d9387ba447d3f3a01dc8c232933e828
Reviewed-on: https://gerrit.instructure.com/59455
Reviewed-by: Andrew Butterfield <abutterfield@instructure.com>
Tested-by: Jenkins
Reviewed-by: Nick Houle <nhoule@instructure.com>
QA-Review: Kausty Saxena <kausty@instructure.com>
Product-Review: Brad Humphrey <brad@instructure.com>

Fixes: CNVS-21906

Test plan:
- Make sure the Use New Styles feature flag is
  set to ON
- Open Theme Editor from your admin account
- Make sure Canvas iframe on right side now
  opens on this page ...
  http://cl.ly/image/2c3k1R3V3U0T
  ... instead of on the Dashboard
- Theme editor should work the same
  as before this change

Change-Id: Ifa38134ba186bc49c12062ae914a004b3664d189
Reviewed-on: https://gerrit.instructure.com/59007
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Myller de Araujo <myller@instructure.com>

Fixes: CNVS-22090

This change involves the location of the
"Switch to Individual View" link on the
gradebook page in both the NUI and legacy
Canvas.

Test Plan:
	- Navigate to the gradebook page.

	- Previously "Switch to Individual View" was
	  part of the breadcrumb as can be seen here:
	  NUI:    http://screencast.com/t/OYLhED9MRo
	  Legacy: http://screencast.com/t/zhrnyd5HF

	- We have made the following changes

		* Instead of a link, it is now a button.

		* It is now located in the gradebook header
		  on the the right side
		  http://www.screencast.com/t/tby7EmuP7ldK

	- Clicking on the button should take you to
	  the corresponding 'Gradebook: Individual
	  View' page.

	- In both legacy Canvas and the NUI the
	  behavior should be the same.

	- NOTE: Because the 'Individual View' link was
	  previously in the breadcrumb, the corresponding
	  gradebook2_srgb_spec was failing because it was
	  still looking for the 'ellipsible' class (a
	  class associated with breadcrumb elements)
	  Because the link has now been removed from the
	  breadcrumb, the 'ellipsible' class was also
	  removed in order to update the spec.

Change-Id: Id53ca2b81904447aa57b8ce527598d08f458056b
Reviewed-on: https://gerrit.instructure.com/59292
Tested-by: Jenkins
Reviewed-by: Spencer Olson <solson@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Myller de Araujo <myller@instructure.com>

fixes: CNVS-22308

test plan:
on your local machine,
compile assets
go to accounts/x (where x is an account with analytics turned on)
make sure you don't see a 404/403 that looks like:
https://du11hjcvx0uqb.cloudfront.net/optimized/plugins/analytics/compiled/bundles/inject_department_analytics.js?1438606697

on beta:
go to:
https://jeremyp.beta.instructure.com/accounts/90336
make sure that does not have 403 js errors

Change-Id: Ia5ce0a969605e85fd8bbe9241d19d5408b591314
Reviewed-on: https://gerrit.instructure.com/59862
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins

fixes CNVS-22231, CNVS-22229, CNVS-22232

Change-Id: Id88f6d80c3eec7c108bf2ad478163cd2afb17314
Reviewed-on: https://gerrit.instructure.com/59827
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Colleen Palmer <colleen@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

fixes CNVS-22283

test plan:
  - go to theme editor
  - if you click on a color's
    label, it focuses on the input
  - if you input an invalid color and
    then inspect element on its input,
    you see aria-invalid is true
    - it is false when it is not invalid

Change-Id: Ic4ff57967f96784942d83d210eb0046d67114b81
Reviewed-on: https://gerrit.instructure.com/59775
Reviewed-by: Ryan Shaw <ryan@instructure.com>
Tested-by: Jenkins
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>

fixes a problem where sometimes quiz points were not correctly
specified because of migration_id collisions

closes #CNVS-22287

Change-Id: I311398570aa6186c9be9c3502329a46a0c30c555
Reviewed-on: https://gerrit.instructure.com/59780
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>

Change-Id: Iaf7d7afe6979dcbefede6792c951d2c0f7ad4c68

Change-Id: Iacd353d41a284b4bb57aa02fb884f711c8cab8e9

Change-Id: I318d94453dad72a1fb287b5be78f1f2a56af8ae0

Change-Id: I72e9b8e87cb13e84cc46a72821b3e482db67d27c

Change-Id: Ibce183960741e97359e52b527f94e612d10d8135

Change-Id: I80e7fa46e42a65ed57d996dab92d714baf4ef37c

Change-Id: I987462e8573d5f29caa9496d187ac3011240fae5

Change-Id: I9c36fdbf0489c6014029d95b2adf5cd4187afd81

Change-Id: I8cc6afecacd4a4943535ad19b785aef6566c16d5

Change-Id: I85eced1a288902ef402487e98410ae975ff1a192

fixes a problem where sometimes quiz points were not correctly
specified because of migration_id collisions

closes #CNVS-22287

Change-Id: I311398570aa6186c9be9c3502329a46a0c30c555
Reviewed-on: https://gerrit.instructure.com/59780
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Clare Strong <clare@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>

fixes CNVS-22252

to ameliorate race conditions between saving and re-filling of cache

Change-Id: I7cee9a447a444e1bd84fc0fa2c16d40b35db3e69
Reviewed-on: https://gerrit.instructure.com/59637
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Nick Nelson <nick@instructure.com>

fixes CNVS-22236

Test Plan:
* Prerequisites: course with assignments, and several modules that have unlock dates.
* Modules with unlock dates in the original course.
* Perform a course copy, setting start and end dates in the future, and select 'Adjust Dates' (the destination dates should be prefilled with the future dates).
* Once the copy is complete, compare the module unlock dates with those of the source course
* The unlock dates should have been properly shifted

Change-Id: I4e880f44f9cf924d6a3dd2a7e34371d845906b1d
Reviewed-on: https://gerrit.instructure.com/59741
Reviewed-by: Jeremy Stanley <jeremy@instructure.com>
Tested-by: Jenkins
QA-Review: Charles Kimball <ckimball@instructure.com>
Product-Review: Dan Minkevitch <dan@instructure.com>

Change-Id: I1a756034d2296d222d14650339f32760e459183b
Reviewed-on: https://gerrit.instructure.com/59918
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Tested-by: Jenkins
Product-Review: Dan Minkevitch <dan@instructure.com>

Fixes: CNVS-21513

Test Plan:
- In Firefox with NVDA enabled, turn on the new UI

- Move through the global nav with NVDA

- Previously, Account and Inbox options had an extra
  link announced (http://screencast.com/t/mAp9jc5tMtjO)

- Now, the Account and Inbox options should be
  consistent with the ones before them (no extra
  'link' is announced)

Change-Id: Ie7267a4a93680c5ea8f066b505148c1b0e42fa31
Reviewed-on: https://gerrit.instructure.com/59669
Tested-by: Jenkins
Reviewed-by: Jennifer Stern <jstern@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Aaron Cannon <acannon@instructure.com>

Treesame-Commit-Id: 6c5175d

Treesame-Commit-Id: 4cf9ccb

Change-Id: I8277df32105e7364154d864c73e102e975f2cc27

in order to serve the css for handlebars files
from a CDN this needs to be set.

Test Plan:

load a page that has handlebars css on it
see that it works

Change-Id: Ie9fec018e2d9fc95e1bb5c1a61b504797fb535a0
Reviewed-on: https://gerrit.instructure.com/60344
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Tested-by: Jenkins
Product-Review: Ryan Shaw <ryan@instructure.com>

Treesame-Commit-Id: 4cfec0f

Treesame-Commit-Id: 4cfec0f

fixes CNVS-22405

test plan
 - go to groups/users
 - it should work

Change-Id: I833b8bb514abf1e0cb4f1ca518e02f09ae0cd3c8
Reviewed-on: https://gerrit.instructure.com/60345
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Jacob Fugal <jacob@instructure.com>
QA-Review: Derek Hansen <dhansen@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>

Change-Id: Ie819d823ad8040e3433e284b691d43078a1cc504
Reviewed-on: https://gerrit.instructure.com/60388
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

Change-Id: Ia15ecf69739284167877e9aec456246d27a53be6
Reviewed-on: https://gerrit.instructure.com/60429
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>

This new version uses nokogiri instead of libxml-ruby.

refs CNVS-22298

test plan: basic regression test on moodle imports.

Change-Id: Iedfc6c2cd8c33fae5d76cd6e77eec293635c1051
Reviewed-on: https://gerrit.instructure.com/59917
Reviewed-by: James Williams  <jamesw@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>

Change-Id: Ie819d823ad8040e3433e284b691d43078a1cc504
Reviewed-on: https://gerrit.instructure.com/60388
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>

This is required for ratom until this PR is merged sparklemotion/nokogiri#1327

refs CNVS-22298

Change-Id: If99e10659b5b17e8cc8e0df49fbf5ba1214b8612
Reviewed-on: https://gerrit.instructure.com/59948
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>

refs CNVS-22298

Change-Id: I4752fa491dcdd8f8f0eea9fb3b9ed63f2d0bb1e9
Reviewed-on: https://gerrit.instructure.com/59981
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>

This reverts commit 1b98577.

Change-Id: I1dc7414c1bc062ac7198626197b3540f5e2ad71a
Reviewed-on: https://gerrit.instructure.com/60447
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: Rob Orton <rob@instructure.com>
QA-Review: Rob Orton <rob@instructure.com>
Tested-by: Rob Orton <rob@instructure.com>

Treesame-Commit-Id: 477e40b

Treesame-Commit-Id: 006af62

Fixes CNVS-22241

Test Plan:
1) Create new course
2) Navigate to Course Setup Checklist on the Home view
3) Follow each item in the checklist and ensure each item
   is checked off correctly as you complete them

Change-Id: Ia65ab7817dcd330107701e6e6641941343d72d24
Reviewed-on: https://gerrit.instructure.com/59999
Tested-by: Jenkins
Reviewed-by: Dan Minkevitch <dan@instructure.com>
QA-Review: Jahnavi Yetukuri <jyetukuri@instructure.com>
Product-Review: Brock Cooper <bcooper@instructure.com>

fixes CNVS-22246

Test plan:

When the new UI feature is enabled:
* The features section on the account settings page should look like:
http://cl.ly/image/1W2y3x0P2y2c (note global JS/CSS includes checkbox)
* The label shoudl be read for the checkbox with supported screen readers

When the new UI feature is disabled:
* The feature section on the account settings page should look like:
http://cl.ly/image/2z3e393Q0e31 (note Global JS/CSS includes checkbox)
(no change from production)

Change-Id: I957d502e24a8ae49f883b072e286dd44af5060c7
Reviewed-on: https://gerrit.instructure.com/60063
Tested-by: Jenkins
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Reviewed-by: Chris Hart <chart@instructure.com>
Product-Review: Chris Hart <chart@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>

Refs CNVS-18768
Fixes CNVS-21514
Fixes CNVS-22172

test plan:
- Set course dates to the past and check the "Users can only
  participate during section dates"
- Set section dates to the present and check the "Users can only
  participate during section dates"
- Assign a quiz to that section
- Take Quiz button should not appear

- Confirm that no quiz taking timing regressions have introduced
  themselves.

  Hierarchy of dates:
  - term dates > course dates
  - course > term if course dates are restricted ("Users can only
    participate...")
  - section > term > course if only section dates are restricted
  - section > course > term if both section and course dates are
    restricted
  - Quiz time limits are always applied unless end_at times (section ||
    term || course) are shorter.
  - Moderation events are properly applied always..

- Create quiz, do not publish it
- View quiz list
- Attempt to view quiz as a teacher
- Attempt to preview quiz as a teacher

Change-Id: I33280c0b188ba9308858837dbea8a7e11f71e0b4
Reviewed-on: https://gerrit.instructure.com/57604
Tested-by: Jenkins
Reviewed-by: Matt Berns <mberns@instructure.com>
QA-Review: Deepeeca Soundarrajan <dsoundarrajan@instructure.com>
Product-Review: Jason Sparks <jsparks@instructure.com>

Change-Id: Ib902f5f62c900364f0f1e4a64dc5686468bcf030
Reviewed-on: https://gerrit.instructure.com/60478
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>

(legacy UI only)

Fixes: CNVS-22426

Test Plan:
- Make sure the Use New Styles feature flag is OFF
- Go to a course with a term date set
- Make sure the context menu now looks like this ...
  http://cl.ly/image/2o3f1h1k1O1y
  ... instead of this:
  http://screencast.com/t/ojQ2dudYV

Change-Id: Ica532f790c93e3506264328fa471ae7f10e229f0
Reviewed-on: https://gerrit.instructure.com/60480
Reviewed-by: Jennifer Stern <jstern@instructure.com>
Product-Review: Jennifer Stern <jstern@instructure.com>
Tested-by: Jenkins
QA-Review: Erin Hallmark <erin@instructure.com>

Change-Id: I99f28a012d153ae87ed7fb00860254a5122519b5
Reviewed-on: https://gerrit.instructure.com/60502
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>

Change-Id: I99f28a012d153ae87ed7fb00860254a5122519b5
Reviewed-on: https://gerrit.instructure.com/60502
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>

test plan:
 * use an access token to do an API request
 * the X-Canvas-Meta header should have a dk key, with a global id

Change-Id: I85139bffb16750a4bfffb241eaaf54de4d9601ae
Reviewed-on: https://gerrit.instructure.com/60597
Tested-by: Jenkins
Reviewed-by: Rob Orton <rob@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>