Style changes + namespace related methods renaming and changes #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornys
approved these changes
May 7, 2024
Frawless
approved these changes
May 7, 2024
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
im-konge
force-pushed
the
namespace-related-changes
branch
2 times, most recently
from
7f88da5
to
7524e34
Compare
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
im-konge
force-pushed
the
namespace-related-changes
branch
from
7524e34
to
0a4d996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
.collect(Collectors.toList()));totoList();)namespacedCommandis written -> thecommandcontains parameterboolean namespacedwhich is needed just for one case -> in thenamespacedCommand-> so this PR little bit refactors thisnamespace()andnamespace()in the clients, as both of the methods does something completely different