Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support language tags other than @de #24

Closed
acka47 opened this issue Aug 23, 2019 · 4 comments · Fixed by #28
Closed

Support language tags other than @de #24

acka47 opened this issue Aug 23, 2019 · 4 comments · Fixed by #28

Comments

@acka47
Copy link
Member

acka47 commented Aug 23, 2019

Today, I published the Educational Subject Classification (ESC) via SkoHub. Everything went fine regarding the process (pushing int eh GitHub master and updating SkoHub via webhook).

For labels to be shown, I had to replace @en tags by de`, see acka47/skos@b791afb

@literarymachine
Copy link
Contributor

Our usage of JSON-LD language maps is reflected in the GraphQL schema we use in Gatsby. This means that we have to list every single supported language as a valid property. We could get around this by not using language maps and simply allow any string as values for @language. This way, we would simply support any language tags. Otherwise we would need a list of languages. The IANA Language Subtag Registry would probably be right source.

@literarymachine
Copy link
Contributor

For labels to be shown, I had to replace @en tags

Support for @en added in dafe1d6.

literarymachine added a commit that referenced this issue Sep 2, 2019
@literarymachine
Copy link
Contributor

@acka47 ae488bd adds support for all language tags.

acka47 added a commit to acka47/skos that referenced this issue Sep 3, 2019
@acka47
Copy link
Member Author

acka47 commented Sep 3, 2019

+1 I tested it, and it works fine, see https://test.skohub.io/acka47/skos/w3id.org/class/esc/scheme.html.

@acka47 acka47 removed their assignment Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants