Add MASTER label + icons for ready status #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivergg
force-pushed
the
improve_ready_status_in_nodes_page
branch
from
68827b2
to
9ac9877
Compare
herbrandson
reviewed
Jan 22, 2020
|
LGTM :) I left one small comment, but nothing critical. |
|
@herbrandson okay, maybe we could improve the sort in another PR. There still the fact that sorting by the first column won't take into account the "MASTER" label with the current change. Is this still okay to merge ? |
mowings
reviewed
Jan 29, 2020
|
Thanks for the awesome work @olivergg! I can't tell you how much I appreciate it |
|
Shouldn't we reopen this PR ? |
|
@olivergg I think we're good. |
|
@herbrandson I mean, this PR has been closed but not merged ... 😅 |
|
@olivergg Yikes! Sorry, I didn't realize. I thought this had been merged. Yes, if this never made it in let's please re-open so we can merge. Sorry about that :( |
|
@herbrandson Here is the new PR #68 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@herbrandson here is a draft PR for #59 . Hacking the sort is a bit trickier than I thought, so for now, it's just some basic things (utf8 symbol icon instead of text and a MASTER label).