Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT refresh expired token #421

Merged
merged 8 commits into from
Jun 5, 2024
Merged

Conversation

adrinjalali
Copy link
Member

HF invalidated our token again, so here's another one.

@BenjaminBossan
Copy link
Collaborator

Yes, tokens were invalidated last week: https://huggingface.co/blog/space-secrets-disclosure

I wonder if we should just deactivate all the tests that are based on HF tokens? Maybe just skip them unless an env var is set, and only run those tests locally? Not sure how relevant these parts of the skops functionality are overall vs the other parts, you probably know better.

@adrinjalali
Copy link
Member Author

codecov action from version 4 automatically switches to tokenless upload, which is useless 😠

https://docs.codecov.com/docs/codecov-uploader#supporting-token-less-uploads-for-forks-of-open-source-repos-using-codecov

@adrinjalali
Copy link
Member Author

issue on codecov side: codecov/codecov-action#1469

@adrinjalali
Copy link
Member Author

I wonder if we should just deactivate all the tests that are based on HF tokens? Maybe just skip them unless an env var is set, and only run those tests locally? Not sure how relevant these parts of the skops functionality are overall vs the other parts, you probably know better.

Yeah those are I think the least used features. We can slowly deprecated them maybe. I would be in support of that. Can do in another PR.

@BenjaminBossan this is now ready for a merge :)

Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care.

Ouch about the matplotlib deprecation and the codecov issue.

Regarding the HF token, there are now fine-grained tokens that can be enabled, for instance, just for specific orgas (as orga tokens no longer exist). Not sure if you used that, but if not it's probably a good idea to switch to that.

If the hub functionality is deprecated, we could skip the tests if the HF token is not set as an env var, which we provide via GH secrets. IIRC, we initially didn't want to do that because of forks, but if the functionality is phased out, it should be fine.

@adrinjalali adrinjalali merged commit 167f125 into skops-dev:main Jun 5, 2024
14 of 16 checks passed
@adrinjalali adrinjalali deleted the ci/token branch June 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants