-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT refresh expired token #421
Conversation
Yes, tokens were invalidated last week: https://huggingface.co/blog/space-secrets-disclosure I wonder if we should just deactivate all the tests that are based on HF tokens? Maybe just skip them unless an env var is set, and only run those tests locally? Not sure how relevant these parts of the skops functionality are overall vs the other parts, you probably know better. |
codecov action from version 4 automatically switches to tokenless upload, which is useless 😠 |
issue on codecov side: codecov/codecov-action#1469 |
Yeah those are I think the least used features. We can slowly deprecated them maybe. I would be in support of that. Can do in another PR. @BenjaminBossan this is now ready for a merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care.
Ouch about the matplotlib deprecation and the codecov issue.
Regarding the HF token, there are now fine-grained tokens that can be enabled, for instance, just for specific orgas (as orga tokens no longer exist). Not sure if you used that, but if not it's probably a good idea to switch to that.
If the hub functionality is deprecated, we could skip the tests if the HF token is not set as an env var, which we provide via GH secrets. IIRC, we initially didn't want to do that because of forks, but if the functionality is phased out, it should be fine.
HF invalidated our token again, so here's another one.