fix: Make dashcast work with audio devices #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the CI failure. The hook ran fine when commiting. |
|
Sorry, that one was on me. I forgot to include it in the dev requirements. |
|
Hm, this is interesting. Have you tried to see if it works? I'm currently having issues discovering my Mi box at all. |
|
Yep, works with soundcloud. |
skorokithakis
approved these changes
May 31, 2018
|
CI fails now for py <3.6 because of |
|
Yep, that's super inconvenient... |
|
How did you resolve this? |
|
I just force-merged, I'll resolve later as I'm very busy now :( |
|
I have some PR's coming up, most of them small. Is there any specific time you'd prefer to deal with this? I can also roll some of the small changes into a couple of PR's, if you prefer. |
|
Nah just send them all in and I'll get to them as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might sound like a silly idea, but it could be useful as a fallback for sites with autoplaying content that is not supported by
youtube-dl.