fix: Give correct error messages with Dashcast #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..the default castcontroller was being returned when Dashcast was active.
|
Is there a downside to just updating requirements? |
Nope, I was just wondering about the intricacies of package versions used in CI builds. |
|
We should update whenever we can, as long as it doesn't break anything. Unfortunately catt is almost impossible to automatically test... |
|
Indeed. Are you ok with this PR? |
skorokithakis
approved these changes
Oct 11, 2018
|
Yep, looks great! |
added 2 commits
October 12, 2018 08:44
..in order to make CI pass
|
Merging is blocked for me when CI has failed, so I took the liberty of updating requirements here. For unknown reasons the dailymotion test still fails, so I gave up and replaced this test with a twitch one. |
|
Looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of my earlier "fix", the wrong
CastControllerwas being returned if the Dashcast app was running on the cc. Resulting in irrelevant error messages when issuing a control command (which the dashcastCastControllerdoes not support).The CI failure is still because of the DailyMotion extractor, which was fixed in the latest release of
youtube-dl. Any ideas? Or should we just update requirements?