Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stratum message ordering fix #192

Merged
merged 4 commits into from
May 31, 2024
Merged

Stratum message ordering fix #192

merged 4 commits into from
May 31, 2024

Conversation

skot
Copy link
Owner

@skot skot commented May 31, 2024

Removed all dependencies on stratum responses coming in order.
for issue: Pool difficulty is not respected #190

@skot
Copy link
Owner Author

skot commented May 31, 2024

tested with;

  • public-pool
  • OCEAN
  • CKPool
  • AntPool
  • BraiinsPool
    • sends rx: {"id":2,"result":null,"error":[21,"ConfigurationOutOfOrder",null]} in response to mining.configure
  • Luxor
  • NiceHash
    • sends {"id":null,"method":"mining.set_extranonce","params":["3263b370affeb0d550",3]} later on, which we don;t handle

@skot skot merged commit 11c1d08 into master May 31, 2024
2 checks passed
@skot skot deleted the ocean_stratum_fix branch May 31, 2024 21:43
aaron3481 pushed a commit to aaron3481/ESP-Miner that referenced this pull request Jun 11, 2024
@skot
Stratum message ordering fix (skot#192)
8508862 
* rough strategy for this fix. needs testing
* seems to be working with OCEAN. need to make sure nothing else is broken
* add version mask debug
* removed stratum setup response results from A/R shares tally
@Georges760 Georges760 mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skot