Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error and incorrect use of MOPointer #2

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

jeremyblalock
Copy link
Contributor

The following issues were fixed:

  • There was an erroneously-placed colon (:) on line 232, this has been removed
  • When err is an MOPointer, err !== null always evaluates to true
  • The error messages were no very helpful when logging err.description()
    • Instead, using err.value(), we are able to print out the actual MOPointer value with a helpful error message
    • err.value().description() would technically also work, but could cause problems if copy/pasted since we will need to ensure that err.value() is not null before calling

@mathieudutour
Copy link
Member

Awesome, thanks!

@mathieudutour mathieudutour merged commit 98713c8 into skpm:master Jan 25, 2018
@TimonVS TimonVS mentioned this pull request Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants