Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typings for GithubCorner component #47

Merged
merged 2 commits into from
Apr 14, 2018
Merged

add typings for GithubCorner component #47

merged 2 commits into from
Apr 14, 2018

Conversation

panmona
Copy link
Contributor

@panmona panmona commented Apr 13, 2018

I use this in a TypeScript project of mine and needed to create typings for it. In order to make it easier for other Typescript users to use this component I added the typings here.

I use this in a TypeScript project of mine and needed to create typings for it. In order to make it easier for other to use this component I added them here.
@skratchdot
Copy link
Owner

Awesome! Thank you! I will merge and publish soon.

@skratchdot skratchdot merged commit 08d2c3f into skratchdot:master Apr 14, 2018
@skratchdot
Copy link
Owner

Thanks @maracuja-juice ! I just published v2.2.0: https://www.npmjs.com/package/react-github-corner

@panmona
Copy link
Contributor Author

panmona commented Apr 14, 2018

Hey cool thanks!
There's still something though that I haven't done correctly with the typings. I'll look into it and submit a new pull when I found out what it is.

@skratchdot
Copy link
Owner

I think I just need to add:

"types": "./lib/GithubCorner.d.ts"

to the package.json per:
https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html

I'll take a look, but will need you to help test if you can :)

@skratchdot
Copy link
Owner

Actually, just moving that file to index.d.ts in the root should fix it. I think I prefer that. I will try and re-publish.

@skratchdot
Copy link
Owner

@maracuja-juice - I just published version 2.3.0. Can you try re-testing?

@panmona panmona deleted the patch-1 branch April 14, 2018 16:30
@panmona
Copy link
Contributor Author

panmona commented Apr 14, 2018

@skratchdot That works perfectly! Thanks a lot for your time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants