avoid consumer Close() hang #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait for confluentinc/confluent-kafka-go#189 before we proceed with this. Not sure if it's the suggested solution. |
agis
suggested changes
May 30, 2018
There was a problem hiding this comment.
We should probably do what edenhill suggests: confluentinc/confluent-kafka-go#189 (comment).
agis
reviewed
Jun 4, 2018
consumer.go
Outdated
| err := c.consumer.Close() | ||
| // need to unassign to be sure the following Close() | ||
| // will return | ||
| // https://github.com/confluentinc/confluent-kafka-go/issues/189 |
There was a problem hiding this comment.
Better add an explicit TODO so that we're reminded to get rid of this when the issue is fixed.
unsubscribe and poll before closing the consumer to avoid Close() hang Closes #59
dtheodor
changed the title
|
PR ready |
agis
approved these changes
Jun 5, 2018
agis
added a commit
that referenced
this pull request
May 24, 2019
This enables us to revert the workaround introduced in #61, which was needed because of confluentinc/confluent-kafka-go#189. Since this bug is fixed in librdkafka 0.11.5, so we can now remove our workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unsubscribe and poll before closing the consumer to avoid Close()
hang
Closes #59
Workaround for confluentinc/confluent-kafka-go#189