Fix handle_missing parameters and standardize input data shape for MinHashEncoder #210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made small modifications to the MinHashEncoder and GapEncoder:
handle_missing=""
becomeszero_impute
, since we actually do not impute missing values with an empty string. Instead we assign them a encoding vector filled with zeros.(N_samples, 1)
(to be consistent with scikit-learn), I updated the MinHashEncoder to behave in the same way.handle_missing="zero_impute"
becomesempty_impute
, since we impute NaN with an empty string""
.