Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] readthedocs failures #122

Closed
fkiraly opened this issue Oct 9, 2023 · 1 comment · Fixed by #125
Closed

[BUG] readthedocs failures #122

fkiraly opened this issue Oct 9, 2023 · 1 comment · Fixed by #125
Labels
bug documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Oct 9, 2023

Since recently, readthedocs builds fail with a json problem.

There was indeed a , missing in switcher.json, but that did not affect the 2.0.1 release, so I'm not sure what is going on here.

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/skpro/envs/121/lib/python3.11/site-packages/sphinx/events.py", line 97, in emit
    results.append(listener.handler(self.app, *args))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/skpro/envs/121/lib/python3.11/site-packages/pydata_sphinx_theme/__init__.py", line 99, in update_config
    switcher_content = json.loads(content)
                       ^^^^^^^^^^^^^^^^^^^
  File "/home/docs/.asdf/installs/python/3.11.4/lib/python3.11/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/.asdf/installs/python/3.11.4/lib/python3.11/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/.asdf/installs/python/3.11.4/lib/python3.11/json/decoder.py", line 353, in raw_decode
    obj, end = self.scan_once(s, idx)
               ^^^^^^^^^^^^^^^^^^^^^^
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 12 column 3 (char 226)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/skpro/envs/121/lib/python3.11/site-packages/sphinx/cmd/build.py", line 293, in build_main
    app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/docs/checkouts/readthedocs.org/user_builds/skpro/envs/121/lib/python3.11/site-packages/sphinx/application.py", line 272, in __init__
    self._init_builder()
  File "/home/docs/checkouts/readthedocs.org/user_builds/skpro/envs/121/lib/python3.11/site-packages/sphinx/application.py", line 343, in _init_builder
    self.events.emit('builder-inited')
  File "/home/docs/checkouts/readthedocs.org/user_builds/skpro/envs/121/lib/python3.11/site-packages/sphinx/events.py", line 108, in emit
    raise ExtensionError(__("Handler %r for event %r threw an exception") %
sphinx.errors.ExtensionError: Handler <function update_config at 0x7f511f19b600> for event 'builder-inited' threw an exception (exception: Expecting ',' delimiter: line 12 column 3 (char 226))

Extension error (pydata_sphinx_theme):
Handler <function update_config at 0x7f511f19b600> for event 'builder-inited' threw an exception (exception: Expecting ',' delimiter: line 12 column 3 (char 226))
@fkiraly fkiraly added bug maintenance Continuous integration, unit testing & package distribution documentation Documentation & tutorials labels Oct 9, 2023
@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 9, 2023

I suspect this is due to the json switcher being the online version of latest, which is broken, rather than the switcher in the repository.

If this theory is correct, the 2.1.0 release should fix the issues.

fkiraly added a commit that referenced this issue Oct 10, 2023
Attempts to fix #122 by pointing
the json switcher to the GitHub location.

Hypothesis: a broken `json` got uploaded to readthedocs, and it will
prevent upload of a correct version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug documentation Documentation & tutorials maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant