[BUG] fix lookup for specialized test classes #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
bug
module:tests
fkiraly
added a commit
that referenced
this pull request
Jan 30, 2024
…#192) This PR fixes API non-compliances in the `sklearn` variance prediction adapters, uncovered by #189: * `sklearn` `ARDRegressor` fails with `X: pd.DataFrame` on `predict` with `return_std=True` scikit-learn/scikit-learn#28310 * `skpro` `SklearnProbaReg.predict` returned `np.ndarray` even if `y` in `fit` was `pd.DataFrame`
fkiraly
added a commit
that referenced
this pull request
Jan 30, 2024
…tiles` when only `_predict_var` is implemented (#191) This PR fixes a unreported bug in `BaseProbaRegressor` where `_predict_interval` and `_predict_quantiles` would raise an `NotImplementedError` when only `_predict_var` is implemented - despite current defaulting logic being sufficient to obtain (normal) quantiles and symmetric (normal) intervals from `_predict` and `_predict_var`. This issue is present with the `sklearn` adapter and delegate descendants, but was not uncovered due to masking by the test bug in #189. The failure is present in test logs of the fix #189, and #189 is used for testing (by merge into).
|
closed by accident? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes lookup for the specialized test classes.
The internal
all_objectscall was passing classes asobject_typeto theskproregistry lookup, which it did not recognize - it should be the type string.As a consequence, the list of classes was coming up empty - instead of containing classes of a given scitype - hence test coverage was reduced since initially when the
skproall_objectsutility was upgraded (which is not long ago but long enough for uncovered failures to creep in). The generic test classesTestAllEstimators,TestAllObjectswere not impacted.Depends on fixes for silent test failures:
_predict_intervaland_predict_quantileswhen only_predict_varis implemented #191sklearnvariance prediction adapter #192CyclicBoostingand QPD tests until #189 failures are resolved #193