[ENH] Pareto distribution #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
enhancement
module:probability&simulation
fkiraly
reviewed
Jun 19, 2024
skpro/distributions/pareto.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| xm : float or array of float (1D or 2D), must be positive |
There was a problem hiding this comment.
xm is as it is on wikipedia, but I think it is confusing since there is another parameter x, below. Shall we name it scale instead?
There was a problem hiding this comment.
Sure, that would be nice. I just used the Wikipedia convention initially as different websites had different names for these two parameters.
There was a problem hiding this comment.
I have implemented the parameter name change from xm to scale, and updated the docstring as such
There was a problem hiding this comment.
Have added the CDF to the docstring for clarity
fkiraly
requested changes
Jun 19, 2024
fkiraly
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #22 for the Pareto distribution
What does this implement/fix? Explain your changes.
Implements some methods for the Pareto distribution
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Current state of code, and how to add energy
Did you add any tests for the change?
No
Any other comments?
No
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skproroot directory (not theCONTRIBUTORS.md). Common badges:code- fixing a bug, or adding code logic.doc- writing or improving documentation or docstrings.bug- reporting or diagnosing a bug (get this pluscodeif you also fixed the bug in the PR).maintenance- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst, follow the pattern.Examplessection.python_dependenciestag and ensureddependency isolation, see the estimator dependencies guide.