Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Truncated Normal distribution #421

Merged
merged 4 commits into from
Jul 27, 2024
Merged

Conversation

ShreeshaM07
Copy link
Contributor

What does this implement/fix? Explain your changes.

Interfaces truncated normal distribution from scipy.

Does your contribution introduce a new dependency? If yes, which one?

No

Did you add any tests for the change?

Yes

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors with any new badges I've earned :-)
    How to: add yourself to the all-contributors file in the skpro root directory (not the CONTRIBUTORS.md). Common badges: code - fixing a bug, or adding code logic. doc - writing or improving documentation or docstrings. bug - reporting or diagnosing a bug (get this plus code if you also fixed the bug in the PR).maintenance - CI, test framework, release.
    See here for full badge reference
  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
For new estimators
  • I've added the estimator to the API reference - in docs/source/api_reference/taskname.rst, follow the pattern.
  • I've added one or more illustrative usage examples to the docstring, in a pydocstyle compliant Examples section.
  • If the estimator relies on a soft dependency, I've set the python_dependencies tag and ensured
    dependency isolation, see the estimator dependencies guide.

:toctree: auto_generated/
:template: class.rst

TruncatedNormal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put it into full reals, since any float can end up in the support.

Alternatively, one could open a new category for interval support, Beta could also move there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now we can move it to full reals itself as we do not have full fledged TruncatedDistribution class for other distributions.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very strange choice of parameterization in scipy, I agree with the choice of reparameterizing as on wikipedia.

I left a comment regarding the right spot in the API reference, would appreciate your opinion.

@fkiraly fkiraly merged commit 3f0ec0c into sktime:main Jul 27, 2024
34 checks passed
@fkiraly fkiraly added the module:probability&simulation probability distributions and simulators label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:probability&simulation probability distributions and simulators
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants