-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Truncated Normal distribution #421
Conversation
:toctree: auto_generated/ | ||
:template: class.rst | ||
|
||
TruncatedNormal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put it into full reals, since any float can end up in the support.
Alternatively, one could open a new category for interval support, Beta
could also move there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for now we can move it to full reals itself as we do not have full fledged TruncatedDistribution class for other distributions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very strange choice of parameterization in scipy
, I agree with the choice of reparameterizing as on wikipedia.
I left a comment regarding the right spot in the API reference, would appreciate your opinion.
What does this implement/fix? Explain your changes.
Interfaces truncated normal distribution from scipy.
Does your contribution introduce a new dependency? If yes, which one?
No
Did you add any tests for the change?
Yes
Any other comments?
PR checklist
For all contributions
How to: add yourself to the all-contributors file in the
skpro
root directory (not theCONTRIBUTORS.md
). Common badges:code
- fixing a bug, or adding code logic.doc
- writing or improving documentation or docstrings.bug
- reporting or diagnosing a bug (get this pluscode
if you also fixed the bug in the PR).maintenance
- CI, test framework, release.See here for full badge reference
For new estimators
docs/source/api_reference/taskname.rst
, follow the pattern.Examples
section.python_dependencies
tag and ensureddependency isolation, see the estimator dependencies guide.