-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting over code from sktime-neuro-draft #5
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
b6f6c76
to
204f68d
Compare
204f68d
to
5755fff
Compare
It does not seem to find mne as a dependency. Do I need to add it somewhere else other than in the setup.py? |
build_tools/requirements.txt perhaps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy to approve this, but for the next you might want to look at adding the docstrings and meta information in the sktime format. Add author at the top, broadly follow goals laid out here https://github.com/alan-turing-institute/sktime/milestone/6
I was looking at one file without so much documentation, I see there is plenty there already. Given this has all been reviewed elsewhere, I will merge it, I find it easier to review in an IDE. |
Changes
- temporal filter
- downsampling
- missing: Artifact Removal
- temporal filter
- downsampling
- slicing
- baseline correction
- epoching
- for filterforseries
- for filterforpanel
- more to follow, not sure how to port tests from sktime though
To dos: