Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting over code from sktime-neuro-draft #5

Merged
merged 11 commits into from
Jul 22, 2021
Merged

Porting over code from sktime-neuro-draft #5

merged 11 commits into from
Jul 22, 2021

Conversation

SveaMeyer13
Copy link
Collaborator

Changes

  • Adjust flake8 in setup.cfg to be compatible with black for pre-commit hooks
  • Add utilities to create mne data format from sktime data format and to create annotations from mne raw object
  • Add series-to-series transformers
    - temporal filter
    - downsampling
    - missing: Artifact Removal
  • Add panel-to-panel transformers
    - temporal filter
    - downsampling
    - slicing
    - baseline correction
  • Add base class for series-to-panel transformer
  • Add series-to-panel transformer
    - epoching
  • Add notebook of example notebook
  • Add tests
    - for filterforseries
    - for filterforpanel
    - more to follow, not sure how to port tests from sktime though

To dos:

  • add artifact removal
  • add/port tests from sktime

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@SveaMeyer13
Copy link
Collaborator Author

It does not seem to find mne as a dependency. Do I need to add it somewhere else other than in the setup.py?

@TonyBagnall
Copy link
Contributor

build_tools/requirements.txt perhaps?

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to approve this, but for the next you might want to look at adding the docstrings and meta information in the sktime format. Add author at the top, broadly follow goals laid out here https://github.com/alan-turing-institute/sktime/milestone/6

@TonyBagnall
Copy link
Contributor

I was looking at one file without so much documentation, I see there is plenty there already. Given this has all been reviewed elsewhere, I will merge it, I find it easier to review in an IDE.

@TonyBagnall TonyBagnall merged commit 378ca63 into main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants