[ENH] Refactor base series annotator - design with tags #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaSP uses `fmt` to change the output format, so it has been kept as a attribute of the `ClaSPSegmentation` class.
fkiraly
added
API design
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
6 tasks
fkiraly
added
the
do not merge
|
Superseded by #6265 - integrated there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, modified variant of the base class design in #6265 where tags are used instead of parametric
super.__init__calls.The change is carried out in the tag registry and base class; the change in concrete classes is carried out only once for demonstration in clasp.
FYI @Alex-JG3, feel free to pull this into your PR, or use this as a template, or ignore it.