[ENH] classification test scenario with three classes and pd-multiindex mtype
#6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:classification
6 tasks
This was referenced May 2, 2024
cedricdonie
reviewed
May 2, 2024
fkiraly
changed the title
pd-multiindex mtype
fkiraly
added a commit
that referenced
this pull request
May 28, 2024
…d-multiindex` mtype (#6491) This fixes an unreported bug where `BaseClassifier.fit_predict` and `fit_predict_proba` would not work for `pd-multiindex` mtype. The failure is due to `cv.split` being called on a multi-index, which applies to `iloc` range index instead of the first `loc` index component of the multi-index. Test coverage is added through the scenario in PR #6374 which covers both `pd-multiindex` as well as the three-class case. This PR also de-duplicates the `_fit_predict_boilerplate` method of `BaseClassifier` with `BasePanelMixin`.
fkiraly
added a commit
that referenced
this pull request
May 29, 2024
…data type (#6377) This PR fixes #6376 by ensuring the `_get_train_probs` method - with undocumented contract - accepts `X_train` of any permissible panel input type. The fix is adding an input converter to numpy3D, which all currently implemented instances seem to assume. This approach should fix the failing `test_classifier_output` test for the new scenario, without removing functionality (even if private), or degrading efficiency in a case where the input is numpy already. Depends on #6374 for testing.
geetu040
pushed a commit
to geetu040/sktime
that referenced
this pull request
Jun 4, 2024
…d-multiindex` mtype (sktime#6491) This fixes an unreported bug where `BaseClassifier.fit_predict` and `fit_predict_proba` would not work for `pd-multiindex` mtype. The failure is due to `cv.split` being called on a multi-index, which applies to `iloc` range index instead of the first `loc` index component of the multi-index. Test coverage is added through the scenario in PR sktime#6374 which covers both `pd-multiindex` as well as the three-class case. This PR also de-duplicates the `_fit_predict_boilerplate` method of `BaseClassifier` with `BasePanelMixin`.
geetu040
pushed a commit
to geetu040/sktime
that referenced
this pull request
Jun 4, 2024
…dex` mtype (sktime#6374) This adds a classification test scenario with three classes and `pd-multiindex` mtype. Currently, only two classes were tested. Depends on bugfixes newly covered: * sktime#6491
geetu040
pushed a commit
to geetu040/sktime
that referenced
this pull request
Jun 4, 2024
…data type (sktime#6377) This PR fixes sktime#6376 by ensuring the `_get_train_probs` method - with undocumented contract - accepts `X_train` of any permissible panel input type. The fix is adding an input converter to numpy3D, which all currently implemented instances seem to assume. This approach should fix the failing `test_classifier_output` test for the new scenario, without removing functionality (even if private), or degrading efficiency in a case where the input is numpy already. Depends on sktime#6374 for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a classification test scenario with three classes and
pd-multiindexmtype.Currently, only two classes were tested.
Depends on bugfixes newly covered:
BaseClassifier.fit_predictandfit_predict_probaforpd-multiindexmtype #6491