[BUG] fix BaggingClassifier for column subsampling case
#6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
added
module:classification
fkiraly
requested review from
achieveordie,
benHeid and
yarnabrina
as code owners
geetu040
pushed a commit
to geetu040/sktime
that referenced
this pull request
Jun 4, 2024
Fixes sktime#6427. The problem was that `_predict_proba` did simply forget to subset columns of `X`. The bug was not detected as the base classifier used in tests was `DummyClassifier`, which ignores `X`, and hence misses the failures in column subsetting of `X` entirely. To cover the bug, the classifier was replaced by `SummaryClassifier.`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6427.
The problem was that
_predict_probadid simply forget to subset columns ofX.The bug was not detected as the base classifier used in tests was
DummyClassifier, which ignoresX, and hence misses the failures in column subsetting ofXentirely.To cover the bug, the classifier was replaced by
SummaryClassifier..