Fixes Parent Relation Lookups #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mochacat
approved these changes
Aug 13, 2018
added 2 commits
August 13, 2018 17:22
mochacat
reviewed
Aug 15, 2018
filter.go
Outdated
| return false | ||
| } | ||
| for i, childMatchValue := range childMatchValues { | ||
| if childMatchValue.Interface() != parentMatchValues[i].Interface() { |
There was a problem hiding this comment.
I've made this mistake before but we probably shouldn't compare the underlying values through Interface(). It will panic if one of the values is a zero value. Also if childMatchValue.IsValid() is false (a zero value), then we should return false.
There was a problem hiding this comment.
Good catch, What do you think about checking "CanInterface" first. I think that should work.
ghost
unassigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a few bugs in the parent relation lookups. This should fix them.