Add deleteExisting metadata tag #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plusplusben
reviewed
Aug 28, 2018
testing.go
Outdated
| @@ -70,6 +77,22 @@ func (eh ExpectationHelper) getUpdateDBColumns() []string { | |||
| return tableMetadata.getColumnNamesForUpdate() | |||
| } | |||
|
|
|||
| /*func (eh ExpectationHelper) getDeletePrimaryKeyValue(object reflect.Value) interface{} { | |||
There was a problem hiding this comment.
Do we still need this?
picard.go
Outdated
|
|
||
| // already exists in updates so delete the existing update that | ||
| // matches the delete | ||
| newUpdates := updates[:0] |
There was a problem hiding this comment.
I'm not sure I understand why this last section is necessary. Let's talk about it when you're at the office.
picard.go
Outdated
| if multitenancyKeyColumnName != "" { | ||
| query = query.Where(fmt.Sprintf("%v.%v = $2", tableName, multitenancyKeyColumnName), p.multitenancyValue) | ||
| arg := "$1" |
There was a problem hiding this comment.
I think I may know of a way that we can avoid doing this. I'll see if I can get it to work.
added 7 commits
August 28, 2018 11:30
plusplusben
reviewed
Aug 29, 2018
| @@ -28,6 +29,41 @@ func (p PersistenceORM) FilterModel(filterModel interface{}) ([]interface{}, err | |||
| return p.FilterModelAssociations(filterModel, nil) | |||
| } | |||
|
|
|||
| // FilterModels returns models that match the provided struct, multiple models can be provided | |||
| func (p PersistenceORM) FilterModels(filterModels interface{}, transaction *sql.Tx) ([]interface{}, error) { | |||
There was a problem hiding this comment.
This basically lets you send multiple models into a "FilterModel" call, and will put their where clauses in parenthesis separated by ORs.
added 2 commits
August 29, 2018 16:00
plusplusben
reviewed
Aug 29, 2018
| @@ -5,7 +5,6 @@ workspace: | |||
| pipeline: | |||
| test: | |||
| image: golang:1.9-alpine | |||
| pull: true | |||
| environment: | |||
There was a problem hiding this comment.
I don't think this was helping any.
plusplusben
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.