Uses Picard Unmarshalling in Tests also improves tests to be explicit… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… about expectations
mochacat
reviewed
Sep 10, 2018
decoding/decoding.go
Outdated
| @@ -8,7 +8,7 @@ import ( | |||
| "github.com/modern-go/reflect2" | |||
| jsoniter "github.com/plusplusben/json-iterator-go" | |||
| "github.com/skuid/picard/metadata" | |||
| "github.com/skuid/warden/pkg/mapvalue" | |||
| "github.com/skuid/picard/stringutils" | |||
stringutils/strings.go
Outdated
| @@ -0,0 +1,11 @@ | |||
| package stringutils | |||
There was a problem hiding this comment.
Some style guides for Go say to only use singular package names (stringutil), not plural (stringutils). Not sure if we should care that much, especially since theres packages like "errors" and "strings" that deviate from this. Just throwing that out there.
mochacat
approved these changes
Sep 10, 2018
ghost
unassigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… about expectations