Add Patch Functionality and Defined Fields to picard metadata #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrhwick I'm thinking I'll write a few more tests for this and clean things up a bit, but I wanted to let you check this out and see if you like the direction. |
mrhwick
approved these changes
Jan 12, 2018
picard.go
Outdated
| @@ -41,7 +43,9 @@ type DBChange struct { | |||
| // Used as an embedded type on a model struct, and certain metadata can be added as struct tags. | |||
| // Currently supported tags: | |||
| // tablename | |||
| type StructMetadata bool | |||
| type StructMetadata struct { | |||
There was a problem hiding this comment.
We might want to take the opportunity to rename this type to something like ModelMetadata since it is storing information about model schema in tags, and dynamically storing different information for internal handling of an instance of a model at run-time.
There was a problem hiding this comment.
What do you think about just calling it "Metadata"
picard.go
Outdated
| @@ -41,7 +43,9 @@ type DBChange struct { | |||
| // Used as an embedded type on a model struct, and certain metadata can be added as struct tags. | |||
| // Currently supported tags: | |||
| // tablename | |||
| type StructMetadata bool | |||
| type StructMetadata struct { | |||
| DefinedFields []string | |||
There was a problem hiding this comment.
Is there a use-case where this needs to be exported? If picard is the only thing stowing information here, then we don't necessarily need to export this field.
added 2 commits
January 12, 2018 13:14
ghost
unassigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Unmarshalling functionality to Picard. If you unmarshal through picard, any undefined fields will be added to picard StructMetadata.
Picard model updates will now read from model metadata to determine if only a partial update was requested.