PLIN-2085: Fixing multitenancy keys on joins to be part of the ON clause #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a left join with multitenancy keys in the WHERE clause causes empty results if there is not a referenced record.
Moving it to the
ON
clause fixes this so that we still get the left table's records even if there is no right table record:This change pulls out the multitenancy key and treats it differently. It still adds it to the WHERE clause for the left most table, but then adds it to the
ON
clause of theJOIN
for all of the other tables.