Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test that failed before fixing the deleting inserts bug #69

Merged
merged 2 commits into from
May 23, 2019

Conversation

plusplusben
Copy link
Contributor

Improve this test so that it accurately reflects reality. Child records that were inserted should be returned from the delete query. The should not be deleted. This test now fails without the new "inserts" check in the deleteFiltering code.

@plusplusben plusplusben self-assigned this May 23, 2019
Copy link

@bnewtonius bnewtonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@plusplusben plusplusben merged commit 8e97b83 into master May 23, 2019
@plusplusben plusplusben deleted the NO-TICKET-improve-test-for-not-deleting-inserts branch May 23, 2019 16:26
@ghost ghost unassigned plusplusben Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants