New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans up the Filtering API, Also Adds Ordering Functionality #75

Merged

plusplusben merged 1 commit into master from cleanup-filter-api-and-add-order-by

Jun 24, 2019

Contributor

plusplusben commented Jun 21, 2019

Change the signature of picard.FilterModel to accept a "FilterRequest" struct. This will allow us to expand the functionality of picard without adding new functions for every feature.
Remove picard.FilterModelAssociations as it's covered in picard.FilterModel now.
Remove picard.FilterModels as it's covered in picard.FilterModel now.
Add the ability to specify fields to order by in a FilterModel request.


          Cleans up the Filtering API, also adds the ability to do ordering in …

7afb52c

…picard

plusplusben requested review from bnewtonius and mochacat

June 21, 2019 20:23

plusplusben self-assigned this

mochacat approved these changes

View reviewed changes

Contributor

mochacat left a comment

Thanks for cleaning this up. It feels much better having one function to handle all types of filtering.

bnewtonius approved these changes

View reviewed changes

plusplusben merged commit 25fe2b0 into master

plusplusben deleted the cleanup-filter-api-and-add-order-by branch

June 24, 2019 14:04

ghost unassigned plusplusben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet