DISPATCH-2039 Add option -DQD_DISABLE_MEMORY_POOL for CMake build #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiridanek
force-pushed
the
jd_2022_03_01_disable_mempool
branch
3 times, most recently
from
e27d7da
to
89f8d9f
Compare
jiridanek
changed the title
jiridanek
force-pushed
the
jd_2022_03_01_disable_mempool
branch
from
6fa2d95
to
ec3fdf8
Compare
kgiusti
reviewed
Mar 9, 2022
| # Safe pointers require memory pool to work (memory may never be relinquished to the OS, otherwise safe pointers may | ||
| # break). Therefore, only disable memory pool for special debugging purposes. Sanitizers minimize memory reuse and | ||
| # make it significantly less likely that a safe pointer breaks. | ||
| set(QD_DISABLE_MEMORY_POOL OFF CACHE STRING "Disables memory pool. Should be only used with asan or msan RUNTIME_CHECK") |
There was a problem hiding this comment.
@jiridanek any chance this patch can for the 'cmake' command to fail if QD_DISABLE_MEMORY_POOL is set but RUNTIME_CHECK is not asan/msan?
Issue a message(FATAL_ERROR... like done elsewhere in this file.
There was a problem hiding this comment.
I guess so, this should thwart the unwarry who might want to compile production build with the option, and put them back on the right path. Not that they would not be taught differently soon enough, the safe pointers break a lot, without sanitizers. (increasing the quarantine_size_mb sanitizer option helps make the router more stable).
kgiusti
approved these changes
Mar 9, 2022
jiridanek
force-pushed
the
jd_2022_03_01_disable_mempool
branch
from
ec3fdf8
to
740b49d
Compare
jiridanek
force-pushed
the
jd_2022_03_01_disable_mempool
branch
from
740b49d
to
c1fb45f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.