-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handling digits in flex mode #483
Comments
skvadrik
added a commit
that referenced
this issue
Jul 19, 2024
This fixes bug #483 "handling digits in flex mode".
I'm not sure why digits were not allowed - probably just an oversight, as flex mode is not the primary one. They don't cause any grammar ambiguities, so I just added them: f2395c2. |
This was certainly an oversight. Apparently we did not end up needing it
despite the complex original use case (convert all flex usage in PHP with
RE2C).
…On Sat, Jul 20, 2024 at 12:04 AM Ulya Trofimovich ***@***.***> wrote:
I'm not sure why digits were not allowed - probably just an oversight, as
flex mode is not the primary one. They don't cause any grammar ambiguities,
so I just added them: f2395c2
<f2395c2>
.
—
Reply to this email directly, view it on GitHub
<#483 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQ7NSKZSJBNPE2SZA5QAI3ZNGEOJAVCNFSM6AAAAABLEY32Q2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBQGMZDMOBVGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the following pattern of integer literal when the -F flag is given:
0|[1-9][0-9]* { /* ... */}
re2rust fails with error
unexpected character: '0'
it requires to add double quotes or character classes around the literal 0
[0]|[1-9][0-9]* { /* ... */}
Should this be a bug in flex mode
The text was updated successfully, but these errors were encountered: