Move primitives to monkey. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required adding/removing 32 from the ASCII values of each character, and that meant adding ORD + CHR (just like BASIC!). Next to move will be ltrim, rtrim, and trim.
Cute implementation via regular-expression :)
Previously this worked by accident!
Rather than golang.
We cannot invoke string.tolower() since they are now defined in the monkey-implementation. We can't load them from there, via static.go, because that is in package main. So for the moment we'll just remove the tests. Shame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request shuffles implementation around so that more of our primitives are written in monkey, rather than go.
That's
This will close #31 when merged.