Allow I/O operations to have a level of indirection. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull-request supersedes #121, which was never merged, as a solution to embedding the interpreter and allowing flexible I/O handling: * Rather than changing our builtin-signatures we introduce a new config/ package. * We pass an instance of the configuration object, containing handles, to the interpreter. * This is then accessed to read/write to STDIN/STDOUT. The test-case for (print), TestPrint, was updated to send output to a faux I/O helper - which is actually a buffer - and shows that the indirection works. And now that we've implemented the I/O helper we've updated (read) to use it appropriately too.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request supersedes #121, which was never merged, as a solution to embedding the interpreter and allowing flexible I/O handling:
The test-case for (print), TestPrint, was updated to send output to a faux I/O helper - which is actually a buffer - and shows that the indirection works.
And now that we've implemented the I/O helper we've updated (read) to use it appropriately too.