Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all dependencies #248

Merged
merged 11 commits into from
Aug 1, 2022
Merged

update all dependencies #248

merged 11 commits into from
Aug 1, 2022

Conversation

aecay
Copy link
Contributor

@aecay aecay commented Jul 29, 2022

the background to this change is that we are preparing to update feed to the networking/v1 Ingress API (from the extensions/v1beta1 API that was previously used, and is now deprecated/removed from recent versions of k8s). in order to accomplish this, we need to update the k8s api libraries to more recent versions. this is a good opportunity to rebaseline our dependencies and shed support for a deprecated module (merlin) within feed. the next version of feed (incorporating the API change) will need to be a major version update, so we can batch these changes with the upcoming ones as well.

  • update go version to 1.18
  • use go get -d -u ./... to pull in the newest version of all dependencies
  • delete the merlin module
    • its test suite relied on calling proto.Clone which does some reflect tricks with private fields that no longer work correctly
    • anyway, merlin is EOL so we don't need to keep supporting it
  • update our usage of the k8s apis
    • pass a context to the functions that demand one
    • comply with the new update apis (passing a name of the filed manager)
    • write some new deep-equal functions for a type (LoadBalancerIngress) that has fields (slices) in it now that are not comparable by simple ==
  • update the k8s test suite to match
    • use autogenerated mocks for the parts that were touched by this update, to make it easier to keep up with future updates
  • update ginkgo to v2
    • this catches an issue in the gorb tests with a misplaced Before/AfterSuite invocation

@aecay aecay marked this pull request as ready for review July 29, 2022 11:59
Copy link
Contributor

@howardburgess howardburgess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to add a CHANGELOG entry.

Copy link

@pyoio pyoio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, decomm all the things!

@aecay
Copy link
Contributor Author

aecay commented Aug 1, 2022

Good shout re the changelog. If it's ok with you, I will do a third PR to prep the changelog and bump the version, after the two open ones are merged in?

@howardburgess
Copy link
Contributor

Sounds fine to me!

@aecay aecay merged commit 765bd1c into master Aug 1, 2022
@aecay aecay deleted the update-deps branch August 1, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants