-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update all dependencies #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be good to add a CHANGELOG entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, decomm all the things!
Good shout re the changelog. If it's ok with you, I will do a third PR to prep the changelog and bump the version, after the two open ones are merged in? |
Sounds fine to me! |
the background to this change is that we are preparing to update feed to the networking/v1 Ingress API (from the extensions/v1beta1 API that was previously used, and is now deprecated/removed from recent versions of k8s). in order to accomplish this, we need to update the k8s api libraries to more recent versions. this is a good opportunity to rebaseline our dependencies and shed support for a deprecated module (merlin) within feed. the next version of feed (incorporating the API change) will need to be a major version update, so we can batch these changes with the upcoming ones as well.
sigs.k8s.io/yaml
modulego get -d -u ./...
to pull in the newest version of all dependenciesmerlin
moduleproto.Clone
which does some reflect tricks with private fields that no longer work correctlyLoadBalancerIngress
) that has fields (slices) in it now that are not comparable by simple==
Before/AfterSuite
invocation