Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new method for removing by ref #78

Merged
merged 2 commits into from
May 24, 2017
Merged

Add new method for removing by ref #78

merged 2 commits into from
May 24, 2017

Conversation

tectiv3
Copy link
Contributor

@tectiv3 tectiv3 commented May 23, 2017

Also fixed tests (replaced container with registry)
PASS ok github.com/skycoin/cxo/node 110.829s
But now every test have this:

HERE ~/.skycoin/cxo/client
22:07:01 conn.go:350: [ERR] [::]:8998 reading error: EOF
22:07:01 conn.go:427: [ERR] [::]:8998 writing error: write tcp [::1]:49831->[::1]:8998: use of closed network connection
22:07:01 conn.go:350: [ERR] [::]:8998 reading error: read tcp [::1]:49837->[::1]:8998: use of closed network connection

Might be related to my fix for container for registry replacement?

@tectiv3
Add new method for removing by ref
882e4bb 
Also fixed tests (replaced container with registry)
tectiv3
tectiv3 commented May 23, 2017
View reviewed changes
node/rootwalker_test.go
@@ -47,7 +47,7 @@ func newClient() *Client {
r.Register("Thread", Thread{})
r.Register("Board", Board{})
r.Done()
c, e := NewClient(NewClientConfig(), skyobject.NewContainer(r))
c, e := NewClient(NewClientConfig(), r)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one.
skyobject.NewContainer Now require DB as a parameter and return *container (surprise)
But client wants registry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

@logrusorgru
Update data_test.go
6c3c61c 
break line on 80th
logrusorgru
logrusorgru approved these changes May 24, 2017
View reviewed changes
data/data_test.go Outdated
@@ -364,8 +364,7 @@ func TestData_DelFeed(t *testing.T) {
})
}

func testRootError(t *testing.T, re *RootError, rp *RootPack,
pk cipher.PubKey) {
func testRootError(t *testing.T, re *RootError, rp *RootPack, pk cipher.PubKey) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

80th symbol is boundary. Fuck wide screens, Fuck horizontal scroll.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol seriously? I have split screen with two textmate windows and it still wider then 80 symbols :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

81

func testRootError(t *testing.T, re *RootError, rp *RootPack, pk cipher.PubKey) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close :))

@logrusorgru logrusorgru merged commit bea21fd into skycoin:master May 24, 2017
tectiv3
tectiv3 commented May 24, 2017
View reviewed changes
data/data_test.go Outdated
@@ -364,7 +364,8 @@ func TestData_DelFeed(t *testing.T) {
})
}

func testRootError(t *testing.T, re *RootError, rp *RootPack, pk cipher.PubKey) {
func testRootError(t *testing.T, re *RootError, rp *RootPack,
pk cipher.PubKey) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, it was breaking my folding

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all right.

@tectiv3
Copy link
Contributor Author

tectiv3 commented May 25, 2017

Guys, what about those network errors?

@logrusorgru
Copy link
Contributor

@tectiv3 use of closed network connection occurs every time you want to read-write (use) a closed network connection.

@tectiv3
Copy link
Contributor Author

tectiv3 commented May 25, 2017 •
edited
Loading

@logrusorgru yeah, I got that, that is pretty much obvious. My question was why and where? Cause I didn't use any connections. My code is at the higher abstraction level. Hence the question. It wasn't there before that registry -> container change. So I'm asking is it related?

@logrusorgru
Copy link
Contributor

Show me the code.

@tectiv3
Copy link
Contributor Author

tectiv3 commented May 25, 2017 •
edited
Loading

well, it's up there ^
this is the only thing that changed in my code.

@logrusorgru
Copy link
Contributor

newClient function uses network

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logrusorgru logrusorgru logrusorgru approved these changes

@evanlinjin evanlinjin evanlinjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tectiv3 @logrusorgru @evanlinjin