Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node test, data/stat->data, node fixes of Subscribe and Unsubscribe of Client #88

Merged
merged 7 commits into from
Jun 1, 2017
Merged

node test, data/stat->data, node fixes of Subscribe and Unsubscribe of Client #88

merged 7 commits into from
Jun 1, 2017

Conversation

logrusorgru
Copy link
Contributor

  1. Misbehavior of node.Client Subscribe and Unsubscribe methods
  • node.Client.Subscribe returns false only if the Client already subscribed to given feed
  • node.Client.Unsubscribe returns false only if the Client is not subscribed to given feed
  • the Unsubscribe method accepts two arguments to allow delete or preserve root objects of feed

  1. Tests for node.Client and node.Server

  2. Package data/stat merged with data.

@logrusorgru logrusorgru merged commit ecaa250 into skycoin:master Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@logrusorgru