Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dmsgpty url commands #178

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Jun 27, 2022

Fixes #_

Changes:

  • add urlCommands function to get commands parameter from pty URL like:
    http://localhost:8000/pty/0224b07107e368e0e58447ed6742b274a797f0cdce4996accb4f2ed7fcc86f06e7?commands=ls,pwd,update
  • each command should separated with , value
  • update command automatically replace with sudo apt update && sudo apt install skywire-bin -y, but other commands run as it put there.
  • ui_html.go gzip hex data changes. It created from this html file with added +location.search to line 10 for WebSocket value. Means changed to new WebSocket(protocol+"://"+location.host+location.pathname+location.search);
  • our modified term.html file is on scripts folder of our repo

How to test this PR:

  • clone dmsg on this PRs branch
  • clone skywire at develop
  • uncomment replace dmsg... on go.mod in skywire and make dep
  • make build and run visor
  • open full terminal of running visor
  • add some commands at related url like ?commands=ls,pwd,update
  • check dmsgpty for commands

Screencast:

dmsgpty.mov

@mrpalide mrpalide changed the base branch from master to develop June 27, 2022 17:40
@jdknives jdknives merged commit 75bc8f8 into skycoin:develop Jun 29, 2022
@mrpalide mrpalide deleted the feature/dmsgpty-url-commands branch October 10, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants