Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C API wrapper for the Skycoin node API #3

Closed
10 tasks
olemis opened this issue Jan 14, 2019 · 1 comment
Closed
10 tasks

C API wrapper for the Skycoin node API #3

olemis opened this issue Jan 14, 2019 · 1 comment
Assignees
@olemis @stdevMac
Labels
openapi Related to REST and OpenAPI specs stdev wip Work in progress
Milestone
0.25.1

Comments

@olemis
Copy link
Contributor

olemis commented Jan 14, 2019 •
edited
Loading

Expected Behavior

Access to the Skycoin node REST API implemented in C code .

Actual Behavior

Right now this is only possible using code generated by SWIG , which requires memory handles

Specifications

  • Version: 0.25.0
  • Platform: all
  • Subsystem: all exported API sets

Possible Solution

Generate it from Swagger specs . Beware of CSRF .

  • Use Skycoin node Swagger spec to generate initial C REST API client
  • Add make target to automate generation in ./build
  • Aforementioned target should copy / merge relevant files into source code tree
  • README explaining the process
  • Mention in CHANGELOG
  • Patch the result Swagger-gen REST client to support specifying node address
  • Update package metadata
  • Run basic Swagger tests in Travis
  • Unify test code in case multiple test suites are used after generation
  • Beware of CSRF auth
@olemis olemis added stdev wip Work in progress openapi Related to REST and OpenAPI specs labels Jan 14, 2019
@olemis olemis mentioned this issue Jan 14, 2019
Open
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Jan 16, 2019
@stdevMac
[stdevMac] refs skycoin#3 -Add swagger spec and milestones to
7005303 
skycoin/libskycoin
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Jan 26, 2019
@stdevMac
[stdevMac] refs skycoin#3 Generated valid swagger
4c29fb7
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 9, 2019
@stdevMac
[stdevMac] refs skycoin#3 Update swagger.yml for skycoin api and addi…
998d11d 
…ng clients

at Ruby, Python and CSharp
@olemis olemis added this to the 0.25.1 milestone Feb 10, 2019
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 11, 2019
@stdevMac
[stdevMac] refs skycoin#3 Update swagger spec with almost all endpoin…
7522204 
…ts for 0.25
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 12, 2019
@stdevMac
[stdevMac] refs skycoin#3 Add swagger operation to Makefile and travi…
49eeb43 
…s-ci, is not working propertly
olemis added a commit to simelo/libskycoin.orig that referenced this issue Feb 13, 2019
@olemis
refs skycoin#3 - Mention lib/swagger in project README
65468e6
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 14, 2019
@stdevMac
[stdevMac] refs skycoin#3 Add swagger operations to README, work prop…
eb39d6b 
…ertly
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 16, 2019
@stdevMac
[stdevMac] refs skycoin#3 Acctualize vendor/github.com/skycoin/skycoin
019b160
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 16, 2019
@stdevMac
[stdevMac] refs skycoin#3 Update skycoin submodule changes
e1dd2d8
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 16, 2019
@stdevMac
[stdevMac] refs skycoin#3 Update skycoin submodule changes
b1407e3
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 16, 2019
@stdevMac
[stdevMac] refs skycoin#3 add C Wrapper for libskycoin and Git
1d33db7
olemis added a commit to simelo/libskycoin.orig that referenced this issue Feb 16, 2019
@olemis
refs skycoin#3 - Move lib/Clients => lib/client and mention in README
244d133
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 16, 2019
@stdevMac
[stdevMac] refs skycoin#3 Add openapi to README.md and Makefile
f728a90
olemis added a commit to simelo/libskycoin.orig that referenced this issue Feb 17, 2019
@olemis
[ci] refs skycoin#3 - Rename make targets for Swagger specs
ac87ec7
olemis added a commit to simelo/libskycoin.orig that referenced this issue Feb 17, 2019
@olemis
[client] refs skycoin#3 - Move C client source code to lib/curl folder
9905562
olemis added a commit to simelo/libskycoin.orig that referenced this issue Feb 17, 2019
@olemis
[client] [swagger] refs skycoin#3 - Update README files
afd82b1
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 19, 2019
@stdevMac
[stdevMac] refs skycoin#3 Update Makefile and Readme from server
f18cf58
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 19, 2019
@stdevMac
[stdevMac] refs skycoin#3 Patch the result Swagger spec to support sp…
59d14fe 
…ecifying node address, for json and yaml
@stdevMac stdevMac mentioned this issue Feb 19, 2019
Closed
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 19, 2019
@stdevMac
[stdevMac] refs skycoin#3 Correct install-deps-swagger in .travis.yml
fe7de16
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 19, 2019
@stdevMac
[stdevMac] refs skycoin#3 Fix issue in .travis.yml
a35659f
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 20, 2019
@stdevMac
[stdevMac] refs skycoin#3 Modify SWAGGER_SPEC_DIR in Makefile
381a5f7
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue Feb 20, 2019
@stdevMac
[stdevMac] refs skycoin#3 Update Makefile to install openapi-tools, c…
aac416d 
… client

generated at ./lib/curl
olemis added a commit to simelo/libskycoin.orig that referenced this issue May 6, 2019
@olemis
[ci] refs skycoin#3 - Remove duplicated CHANGELOG sections
6d64363
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 6, 2019
@stdevMac
[skyapi] refs skycoin#3 Update cmake target
f95f928
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 6, 2019
@stdevMac
[skyapi] refs skycoin#3 Added basic install to skyapi in travis
749add7
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 7, 2019
@stdevMac
[ci] refs skycoin#3 Update Makefile
fc7ca0a
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 7, 2019
@stdevMac
[ci] refs skycoin#3 Updated .travis for propertly cmake installation …
b271b34 
…in osx
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 7, 2019
@stdevMac
[ci] refs skycoin#3 Remove cmake installation in osx
ce4e369
olemis added a commit to simelo/libskycoin.orig that referenced this issue May 8, 2019
@olemis
[swagger] refs skycoin#3 - Correct contact info for Skycoin
5c93816
olemis added a commit to simelo/libskycoin.orig that referenced this issue May 8, 2019
@olemis
[swagger] refs skycoin#3 - Minor changes in Swagger README
2652fff
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[skyapi] refs skycoin#3 Update Makefile for skyapi deps installation
c4c4b65
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[skyapi] refs skycoin#3 Setup lib/curl install in travis and makefile
bf22a93
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[ci] refs skycoin#3 Updated skyapi installation process in travis
b433aea
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[ci] refs skycoin#3 Update makefile to build in mac os
b465684
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[ci] refs skycoin#3 Added -p flag to mkdir in libraries build
0935e34
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[ci] refs skycoin#3 Removed uninstall curl from Makefile
71b4d48
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[skyapi] refs skycoin#3 Set makefile to old position for compile library
0880c47
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[ci] refs skycoin#3 Put installation of skyapi in oneline
1984b54
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[ci] refs skycoin#3 Update travis configuration
4e23cde
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 10, 2019
@stdevMac
[skyapi] refs skycoin#3 Update cmake to use gcc
f810a7a
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 11, 2019
@stdevMac
[skyapi] refs skycoin#3 Renamed flag for cmake in Makefile
8f5085d
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 11, 2019
@stdevMac
[skyapi] refs skycoin#3 Updated gcc compiler to cmake in Makefile
15f1624
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 11, 2019
@stdevMac
[skyapi] refs skycoin#3 Update travis for gcc compiler as default
54c9c20
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 11, 2019
@stdevMac
[ci] refs skycoin#3 Set lib-curl installation to bash file
51b7e09
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
@stdevMac
[swagger] refs skycoin#3 Updated swagger spec
fe4b484
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
@stdevMac
[skyapi] refs skycoin#3 Updated lib/curl for new swagger specification
19574ad
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
@stdevMac
[swagger] refs skycoin#3 Update contact email in swagger spec
90d174b
stdevMac added a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
@stdevMac
[skyapi] refs skycoin#3 Updated skycoin contact in lib/curl
b17ca09
olemis added a commit that referenced this issue May 15, 2019
@olemis
Merge pull request #26 from simelo/stdevMac_t3_v0.25.1_C_Wrapper_Skyc…
57fa05b 
…oin_Api

fixes #3 fixes #40 - v0.25.1 C wrapper skycoin api based on libcurl
@olemis
Copy link
Contributor Author

olemis commented May 15, 2019

fixed in 57fa05b

@olemis olemis closed this as completed May 15, 2019
@vidya88 vidya88 mentioned this issue Sep 20, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olemis olemis

@stdevMac stdevMac

Labels
openapi Related to REST and OpenAPI specs stdev wip Work in progress
Projects
None yet
Milestone
0.25.1
Development

Successfully merging a pull request may close this issue.

fixes #3 - Swagger-generated client for the Skycoin REST API simelo/libskycoin.orig
2 participants
@olemis @stdevMac