Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS Installer Package #1242

Merged
merged 12 commits into from
Jun 17, 2022
Merged

MacOS Installer Package #1242

merged 12 commits into from
Jun 17, 2022

Conversation

mrpalide
Copy link
Contributor

@mrpalide mrpalide commented Jun 2, 2022

Did you run make format && make check? Yes

Fixes # MacOS Installer Package

Changes:

  • fix mac installer script
  • add step to release for create both amd64 and arm64 installer on AppVeyor

How to test this PR:

  • Install jq and wget by brew install ... on your machine
  • Clone this PR
  • Run ./scripts/mac_installer/create_installer.sh

@jdknives
Copy link
Member

 skycoinci@Mac-mini  ~/go/src/github.com/skycoin/skywire   fix/darwin-dmg-package ±  ./scripts/mac_installer/create_installer.sh -x
./scripts/mac_installer/create_installer.sh: line 9: go: command not found
WARN: Unknown option (ignored): -x
No output flag provided, storing installer to the current directory: /Users/skycoinci/go/src/github.com/skycoin/skywire/
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  382k    0  382k    0     0   375k      0 --:--:--  0:00:01 --:--:--  375k
Fetching binary releases from 
wget: missing URL
Usage: wget [OPTION]... [URL]...

Try `wget --help' for more options.

Is it supposed to be possible to build the installers without providing the signing certificates? It seems like the download link is not constructed correctly. Its empty when called.

@mrpalide
Copy link
Contributor Author

Is it supposed to be possible to build the installers without providing the signing certificates? It seems like the download link is not constructed correctly. Its empty when called.

Based on your output, I found a useless go command and fixed it.
Also you need to installed jq, for getting last release tag from github. I forgot to note about it on PR description, and now added. Install it by brew install jq.

@jdknives jdknives merged commit 04f87e4 into skycoin:develop Jun 17, 2022
@mrpalide mrpalide deleted the fix/darwin-dmg-package branch June 18, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants