Fix UI update button #1349
Merged
Fix UI update button #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR i to decouple the process which updates the skywire package installation from the running visor process.
With v1.1.0, the update may succeed in terms of the visor restarting on the new version; however, at the moment the process is restarted dpkg has not finished installing the package and was interrupted from doing so. This leaves the system and installation in an unclean state and will require manual intervention from users to fix it.
I have also defined UpdateCommand functions for windows and mac without actually implementing any update for these.
Did you run
make format && make check?yes
Depends:
Fixes unclean update when UI button is clicked
Changes:
How to test this PR:
click the update button in the UI.
robust testing is not possible at the moment because updating assumes that you have a package-based installation and the repository configured via the skybian package.
The skywire-install.service is itself working and currently used in the new skybian images
this service and the repository configuration are proided by the skybian package in the apt repo at deb.skywire.skycoin.com.