Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/expose dmsghttp server #1374

Merged
merged 14 commits into from
Oct 3, 2022
Merged

Feat/expose dmsghttp server #1374

merged 14 commits into from
Oct 3, 2022

Conversation

ersonp
Copy link
Contributor

@ersonp ersonp commented Sep 26, 2022 •
edited
Loading

Did you run make format && make check?

Fixes #1364

Changes:

  • Added new module dmsghttp_logserver
  • Added field log_rotation_interval to config

How to test this PR:

@ersonp ersonp marked this pull request as ready for review September 27, 2022 13:57
jdknives
jdknives reviewed Sep 28, 2022
View reviewed changes
pkg/visor/init.go Outdated Show resolved Hide resolved
pkg/visor/init.go Outdated Show resolved Hide resolved
pkg/visor/init.go Outdated Show resolved Hide resolved
pkg/visor/init.go Outdated Show resolved Hide resolved
pkg/visor/init.go Show resolved Hide resolved
pkg/visor/init.go Outdated Show resolved Hide resolved
pkg/visor/visorconfig/services.go Outdated Show resolved Hide resolved
@0pcom 0pcom merged commit 6658b87 into skycoin:develop Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdknives jdknives jdknives left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ersonp @jdknives @0pcom