Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VPN client remote startup #470

Merged
merged 17 commits into from
Aug 13, 2020
Merged

Fix VPN client remote startup #470

merged 17 commits into from
Aug 13, 2020

Conversation

Darkren
Copy link
Contributor

@Darkren Darkren commented Aug 13, 2020

Did you run make format && make check?
Yes
Fixes #467

Changes:

  • VPN client now gracefully handles slice of direct IPs containing equal ones
  • Wait is now called correctly for app process. This way app process correctly finishes in case of failure and hypervisor correctly gets its status

How to test this PR:

  1. Start hypervisor
  2. Start visor
  3. From web UI run the app which is said to fail (i.e. VPN client without remote PK set)
  4. You will see that the process started in the UI message, which is true, but you also will see an error in app logs. App will stay down in the UI. It may also happen that app will appear is running. But it will get down during next status update

@Darkren Darkren changed the base branch from master to develop August 13, 2020 12:09
@Darkren Darkren changed the title [WIP] Fix VPN client remote startup Fix VPN client remote startup Aug 13, 2020
jdknives
jdknives approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue. This can be merged after a codereview.

@jdknives jdknives merged commit fecd744 into skycoin:develop Aug 13, 2020
@jdknives jdknives mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov approved these changes

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starting VPN client leads to connection shutdown
3 participants
@Darkren @nkryuchkov @jdknives